Skip to content

chore(sepolia): add incident multisig signer task#682

Open
jackchuma wants to merge 12 commits into
mainfrom
sepolia-incident-multisig-signers-2026-05-13
Open

chore(sepolia): add incident multisig signer task#682
jackchuma wants to merge 12 commits into
mainfrom
sepolia-incident-multisig-signers-2026-05-13

Conversation

@jackchuma
Copy link
Copy Markdown
Contributor

@jackchuma jackchuma commented May 13, 2026

Summary

  • add the Sepolia Incident Multisig signer update task under sepolia/2026-05-13-incident-multisig-signers
  • apply the same owner diff to the Incident Multisig (0x646132A1667ca7aD00d36616AFBA1A28116C770A) and Safe B (0x6AF0674791925f767060Dd52f7fB20984E8639d8)
  • add UpdateSigners.s.sol, which reads OwnerDiff.json, preserves each safe's current threshold, updates the Safe owner linked list, and post-checks the expected owner set
  • add task docs, facilitator instructions, Foundry config, env config, and Make targets for generating validations and executing either safe update
  • include generated signer validation files for both safes and pin the signer tool to 43c55040fee45ec90a33400b10215f1756687ad7

Signer changes

Adds:

  • 0x623942f433Ee569Df78Dceac754C2ed3A3343A80
  • 0xE167153964d4ba0819E1Ad56172F3329cD5A0263
  • 0x98EAC95c208b74d31550fDA9dD3AD62C5d462DF9
  • 0x821Ff2A3fB66B008fA668B40Eca9d3535B246575

Removes:

  • 0x931E24B032511d8dD029AedeB44837FAc251f3d8
  • 0xE45AC81eA7f53dea5f0bd6Caa0733DD5c02d3b60
  • 0x7f10098BD53519c739cA8A404afE127647D94774
  • 0xEE316Db0eDaee45347DfC498795a01311F085225

Validation files

  • Incident Multisig: sepolia/2026-05-13-incident-multisig-signers/validations/base-signer.json
  • Safe B: sepolia/2026-05-13-incident-multisig-signers/validations/base-signer-safe-b.json

Testing

  • jq empty sepolia/2026-05-13-incident-multisig-signers/OwnerDiff.json
  • jq empty sepolia/2026-05-13-incident-multisig-signers/validations/base-signer.json
  • jq empty sepolia/2026-05-13-incident-multisig-signers/validations/base-signer-safe-b.json
  • forge fmt --check sepolia/2026-05-13-incident-multisig-signers/script/UpdateSigners.s.sol

Notes

  • Task status is READY TO SIGN.
  • Signers should run make sign-task from the repo root and select sepolia/2026-05-13-incident-multisig-signers in the signing UI.
  • The simulation sender is 0x644d0F5c2C55A4679b4BFe057B87ba203AF9aC0D.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented May 13, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

Set up a Sepolia safe-management task for adding and removing multiple Incident Multisig signers with placeholder owner diffs.

Co-authored-by: Codex <noreply@openai.com>
@jackchuma jackchuma force-pushed the sepolia-incident-multisig-signers-2026-05-13 branch from abee30e to b7bead1 Compare May 13, 2026 20:31
jackchuma and others added 11 commits May 13, 2026 16:40
Use the latest base/contracts commit and trim explicit Foundry remappings to the remaining base-contracts alias. Update imports for the latest base/contracts scripts directory layout.

Co-authored-by: Codex <noreply@openai.com>
Replace placeholder Sepolia Incident Multisig owner add and remove entries with the requested signer addresses.

Co-authored-by: Codex <noreply@openai.com>
Set the Sepolia Incident Multisig task sender to a current owner that is not removed by the task.

Co-authored-by: Codex <noreply@openai.com>
Set the task docs to ready-to-sign and include facilitator validation and execution guidance.

Co-authored-by: Codex <noreply@openai.com>
Restore the Sepolia task to the intended incident multisig and set the Foundry EVM to Shanghai so the newer Safe proxy bytecode simulates correctly.

Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Add the secondary Safe B address, validation generation, execution target, and generated validation artifact for the Sepolia incident multisig signer task.

Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@jackchuma jackchuma marked this pull request as ready for review May 13, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants