Skip to content

chore(CHAIN-3362): clean up mentions of OP_COMMIT #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackchuma merged 1 commit into from
Mar 13, 2026
Merged

chore(CHAIN-3362): clean up mentions of OP_COMMIT #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ This template is used to pause or un-pause the L1 SuperchainConfig contract.

1. Ensure you have followed the instructions above in `setup`.
1. Run `make setup-superchain-config-pause network=<network>` and go to the folder that was created by this command.
1. Specify the commit of [Optimism code](https://github.com/ethereum-optimism/optimism) and [Base contracts code](https://github.com/base/contracts) you intend to use in the `.env` file.
1. Specify the commit of [Base contracts code](https://github.com/base/contracts) you intend to use in the `.env` file.
1. Run `make deps`.
1. Fill in any task-specific variables in the `.env` file that have per-network comments, using the value for your target network.
1. Build the contracts with `forge build`.
Expand Down
1 change: 0 additions & 1 deletion setup-templates/template-funding/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ SCRIPT_NAME = FundScript
# Validate required configuration before execution
.PHONY: validate-config
validate-config:
@test -n "$(OP_COMMIT)" || (echo "OP_COMMIT required" && exit 1)
@test -n "$(BASE_CONTRACTS_COMMIT)" || (echo "BASE_CONTRACTS_COMMIT required" && exit 1)
@test -n "$(OWNER_SAFE)" || (echo "OWNER_SAFE required" && exit 1)
@test -n "$(SENDER)" || (echo "SENDER required" && exit 1)
Expand Down
1 change: 0 additions & 1 deletion setup-templates/template-gas-and-elasticity-increase/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ SCRIPT_NAME = IncreaseEip1559ElasticityAndIncreaseGasLimitScript
# Validate required configuration before execution
.PHONY: validate-config
validate-config:
@test -n "$(OP_COMMIT)" -a "$(OP_COMMIT)" != "TODO" || (echo "OP_COMMIT required" && exit 1)
@test -n "$(BASE_CONTRACTS_COMMIT)" -a "$(BASE_CONTRACTS_COMMIT)" != "TODO" || (echo "BASE_CONTRACTS_COMMIT required" && exit 1)
@test -n "$(OWNER_SAFE)" || (echo "OWNER_SAFE required" && exit 1)
@test -n "$(SYSTEM_CONFIG)" || (echo "SYSTEM_CONFIG required" && exit 1)
Expand Down
1 change: 0 additions & 1 deletion setup-templates/template-gas-increase/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ SCRIPT_NAME = lib/base-contracts/script/deploy/l1/SetGasLimit.sol
# Validate required configuration before execution
.PHONY: validate-config
validate-config:
@test -n "$(OP_COMMIT)" -a "$(OP_COMMIT)" != "TODO" || (echo "OP_COMMIT required" && exit 1)
@test -n "$(BASE_CONTRACTS_COMMIT)" -a "$(BASE_CONTRACTS_COMMIT)" != "TODO" || (echo "BASE_CONTRACTS_COMMIT required" && exit 1)
@test -n "$(L1_SYSTEM_CONFIG_ADDRESS)" || (echo "L1_SYSTEM_CONFIG_ADDRESS required" && exit 1)
@test -n "$(SYSTEM_CONFIG_OWNER)" || (echo "SYSTEM_CONFIG_OWNER required" && exit 1)
Expand Down
3 changes: 1 addition & 2 deletions setup-templates/template-generic/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ SCRIPT_NAME = ExampleMultisigScript
# Validate required configuration before execution
.PHONY: validate-config
validate-config:
@test -n "$(OP_COMMIT)" || (echo "OP_COMMIT required" && exit 1)
@test -n "$(BASE_CONTRACTS_COMMIT)" || (echo "BASE_CONTRACTS_COMMIT required" && exit 1)
@test -n "$(OWNER_SAFE)" -a "$(OWNER_SAFE)" != "<SET_MULTISIG_ADDRESS>" || (echo "OWNER_SAFE required" && exit 1)
@test -n "$(TARGET)" -a "$(TARGET)" != "<SET_TARGET_ADDRESS>" || (echo "TARGET required" && exit 1)
Expand All @@ -28,4 +27,4 @@ approve-l1-1:
# Execute
.PHONY: execute
execute: validate-config
$(call MULTISIG_EXECUTE,0x)
$(call MULTISIG_EXECUTE,0x)
1 change: 0 additions & 1 deletion setup-templates/template-generic/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ Edit `.env` and set all required variables:

| Variable | Required | Description |
|----------|----------|-------------|
| `OP_COMMIT` | Yes | Git commit hash for ethereum-optimism/optimism |
| `BASE_CONTRACTS_COMMIT` | Yes | Git commit hash for base/contracts |
| `TARGET` | Yes | Target contract address for the operation |
| `OWNER_SAFE` | Yes | Top-level Gnosis Safe address |
Expand Down
1 change: 0 additions & 1 deletion setup-templates/template-pause-bridge-base/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ SCRIPT_NAME = PauseBridge
# Validate required configuration before execution
.PHONY: validate-config
validate-config:
@test -n "$(OP_COMMIT)" || (echo "OP_COMMIT required" && exit 1)
@test -n "$(BASE_CONTRACTS_COMMIT)" || (echo "BASE_CONTRACTS_COMMIT required" && exit 1)
@test -n "$(OWNER_SAFE)" || (echo "OWNER_SAFE required" && exit 1)
@test -n "$(L1_PORTAL)" || (echo "L1_PORTAL required" && exit 1)
Expand Down
1 change: 0 additions & 1 deletion setup-templates/template-safe-management/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ SCRIPT_NAME = UpdateSigners
# Validate required configuration before execution
.PHONY: validate-config
validate-config:
@test -n "$(OP_COMMIT)" -a "$(OP_COMMIT)" != "TODO" || (echo "OP_COMMIT required" && exit 1)
@test -n "$(BASE_CONTRACTS_COMMIT)" -a "$(BASE_CONTRACTS_COMMIT)" != "TODO" || (echo "BASE_CONTRACTS_COMMIT required" && exit 1)
@test -n "$(OWNER_SAFE)" -a "$(OWNER_SAFE)" != "TODO" || (echo "OWNER_SAFE required" && exit 1)
@test -n "$(SENDER)" -a "$(SENDER)" != "TODO" || (echo "SENDER required" && exit 1)
Expand Down
1 change: 0 additions & 1 deletion setup-templates/template-set-bridge-partner-threshold/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ SCRIPT_NAME = SetThreshold
# Validate required configuration before execution
.PHONY: validate-config
validate-config:
@test -n "$(OP_COMMIT)" || (echo "OP_COMMIT required" && exit 1)
@test -n "$(BASE_CONTRACTS_COMMIT)" || (echo "BASE_CONTRACTS_COMMIT required" && exit 1)
@test -n "$(OWNER_SAFE)" || (echo "OWNER_SAFE required" && exit 1)
@test -n "$(L1_PORTAL)" || (echo "L1_PORTAL required" && exit 1)
Expand Down
1 change: 0 additions & 1 deletion setup-templates/template-switch-to-permissioned-game/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ SCRIPT_NAME = SwitchToPermissionedGame
# Validate required configuration before execution
.PHONY: validate-config
validate-config:
@test -n "$(OP_COMMIT)" || (echo "OP_COMMIT required" && exit 1)
@test -n "$(BASE_CONTRACTS_COMMIT)" || (echo "BASE_CONTRACTS_COMMIT required" && exit 1)
@test -n "$(OWNER_SAFE)" || (echo "OWNER_SAFE required" && exit 1)
@test -n "$(SYSTEM_CONFIG)" || (echo "SYSTEM_CONFIG required" && exit 1)
Expand Down
1 change: 0 additions & 1 deletion setup-templates/template-upgrade-fault-proofs/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ OP_SIGNER_SAFE_ADDR ?= $(OP_MULTISIG)
# Validate required configuration before execution
.PHONY: validate-config
validate-config:
@test -n "$(OP_COMMIT)" || (echo "OP_COMMIT required" && exit 1)
@test -n "$(BASE_CONTRACTS_COMMIT)" || (echo "BASE_CONTRACTS_COMMIT required" && exit 1)
@test -n "$(ABSOLUTE_PRESTATE)" || (echo "ABSOLUTE_PRESTATE required" && exit 1)
@test -n "$(SYSTEM_CONFIG)" || (echo "SYSTEM_CONFIG required" && exit 1)
Expand Down
Loading