Add IdP settings command #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablosole
suggested changes
Jun 16, 2021
cmd/settings-idp-set-saml.go
Outdated
|
|
||
| // "certificate": "cert", | ||
| // "entity_id": "entity", | ||
| // "sso_url": "redir" |
There was a problem hiding this comment.
leftover?
also, I think we should print the part that the admin needs to put in the SAML provider, like we do in the EC.
Contributor
Author
There was a problem hiding this comment.
Sounds good. Should that be a specific command? Or print after you set it
There was a problem hiding this comment.
I would print it when you set it yes
Contributor
Author
There was a problem hiding this comment.
@pablosole I can't seem to override base path on swagger - and just noticed that the provider settings is /sp/settings without /api/v1. Can we map it inside? Or there's a reason this is not inside /api/v1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.