feat(plugins): migrate keystore CLI from FullNode to Toolkit#12

Open

barbatos2011 wants to merge 33 commits into

001-keystore-toolkit-migration

Commits on Apr 21, 2026

refactor(crypto): extract keystore library from framework module

Barbatos
authored and
Barbatos
committed
feat(plugins): add keystore new and import commands to Toolkit

Barbatos
authored and
Barbatos
committed
feat(plugins): add keystore list and update commands, deprecate --keystore-factory

Barbatos
authored and
Barbatos
committed
fix(plugins): handle duplicate-address keystores and add import warning

Barbatos
authored and
Barbatos
committed
fix(plugins): block duplicate import, improve error messages and security tips

Barbatos
authored and
Barbatos
committed
style(plugins): use picocli output streams and address review findings

Barbatos
authored and
Barbatos
committed
fix(plugins): secure keystore file creation and improve robustness

Barbatos
authored and
Barbatos
committed
test(plugins): improve keystore test coverage and assertions

Barbatos
authored and
Barbatos
committed
fix(plugins): unify keystore validation and fix inconsistent error messages

Barbatos
authored and
Barbatos
committed
test(plugins): improve coverage for keystore validation and edge cases

Barbatos
authored and
Barbatos
committed
test(plugins): add direct unit tests for KeystoreCliUtils

Barbatos
authored and
Barbatos
committed
test(framework): expand coverage for WalletFile POJO and KeystoreFactory

Barbatos
authored and
Barbatos
committed
ci: re-trigger build after transient apt mirror failure

Barbatos
authored and
Barbatos
committed
ci: re-trigger after transient infrastructure failure

Barbatos
authored and
Barbatos
committed
fix(crypto): enforce keystore address consistency in Wallet.decrypt

Barbatos
authored and
Barbatos
committed
fix(plugins): prevent address spoofing in keystore update command

Barbatos
authored and
Barbatos
committed
docs(plugins): document keystore list address trust model

Barbatos
authored and
Barbatos
committed
refactor(crypto): centralize secure keystore file writing in WalletUtils

Barbatos
authored and
Barbatos
committed
fix(plugins): reject symlinked password/key files to prevent file disclosure

Barbatos
authored and
Barbatos
committed
fix(crypto): preserve whitespace in non-TTY password input

Barbatos
authored and
Barbatos
committed
feat(plugins): hint at legacy password-truncation on keystore update failure

Barbatos
authored and
Barbatos
committed
feat(framework): hint at legacy password-truncation on SR startup failure

Barbatos
authored and
Barbatos
committed

Commits on Apr 22, 2026

test(crypto): move keystore tests to framework for jacoco coverage

Barbatos
authored and
Barbatos
committed
fix(plugins): reject symlinks in keystore directory scans

Barbatos
authored and
Barbatos
committed
fix(plugins): reject multi-line password files in keystore new/import

Barbatos
authored and
Barbatos
committed

Commits on Apr 23, 2026

fix(crypto): reject JSON stubs missing cipher/KDF from keystore discovery

Barbatos
authored and
Barbatos
committed
refactor(crypto): rename misleading Wallet.AES_128_CTR to PBKDF2

Barbatos
authored and
Barbatos
committed

Commits on Apr 24, 2026

refactor(crypto): remove unused web3j-era helpers from WalletUtils

Barbatos
authored and
Barbatos
committed

Commits on Apr 25, 2026

feat(crypto): warn when SR keystore is a symbolic link

Barbatos
authored and
Barbatos
committed
fix(plugins): close TOCTOU window in keystore directory scans

Barbatos
authored and
Barbatos
committed
docs(plugins): correct keystore CLI option names in README

Barbatos
authored and
Barbatos
committed
fix(plugins): reject password files with more than two lines

Barbatos
authored and
Barbatos
committed
test(framework): add SR keystore loading regression tests

Barbatos
authored and
Barbatos
committed