Skip to content

Conversation

@bannzai
Copy link
Owner

@bannzai bannzai commented Oct 9, 2021

Links

resolved: #278

@codecov-commenter
Copy link

Codecov Report

Merging #279 (ab59025) into master (249acf0) will decrease coverage by 12.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #279       +/-   ##
===========================================
- Coverage   93.93%   81.58%   -12.36%     
===========================================
  Files           8       23       +15     
  Lines         132     1575     +1443     
===========================================
+ Hits          124     1285     +1161     
- Misses          8      290      +282     
Impacted Files Coverage Δ
Framework/Sources/SpreadsheetViewDataSource.swift 0.00% <ø> (ø)
Framework/Sources/SpreadsheetViewDelegate.swift 0.00% <ø> (ø)
Framework/Sources/ScrollView.swift 54.76% <0.00%> (-45.24%) ⬇️
Framework/Sources/LayoutEngine.swift 80.06% <0.00%> (-19.94%) ⬇️
Framework/Sources/SpreadsheetView.swift 90.16% <0.00%> (-9.84%) ⬇️
Framework/Sources/ReuseQueue.swift 92.00% <0.00%> (-8.00%) ⬇️
Framework/Sources/Cell.swift 94.73% <0.00%> (-5.27%) ⬇️
Framework/Sources/CircularScrolling.swift 95.13% <0.00%> (-3.14%) ⬇️
...k/Sources/SpreadsheetView+CirclularScrolling.swift 79.71% <0.00%> (ø)
Framework/Sources/Location.swift 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f881358...ab59025. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I think protocol should inherit from AnyObject.

2 participants