Fixes trying to access array offset on value of type resource on PHP 7.4

[srosato]

With PHP 7.4, we get the error "Trying to access array offset on value of type resource". The commit fixes this.

[danfraticiu]

Any chance somebody can merge this PR? 🤞 Thanks

[AlexandruB30]

On PHP 8 we get the error "Uncaught Error: Cannot use object of type CurlHandle as array in HttpConnector" that is also fixed with this additional line of code

[alexis-coulombe]

This PR should be merged asap.

[srosato]

I have merged master into this branch and removed my unnecessary space linting that was automatically done by my IDE in order to keep the diff simple on this merge

[bogdanbradeanu]

are you guys gonna merge this?

[boily]

Please, merge this pull request. It is a Fatal error in php 8.1

[mgrenierfarmmedia]

Yes, this is breaking in PHP 8.1. Fixe it simple to merge, please do so.

[bradlymcgregorhale]

I've reached to Bambora support (ticket number 731671) to see if anyone can help us get this PR merged.

[MiguelLaforest]

Any news from the support team? On my side, the issue suddenly disappeared for successful transactions, but comes back when there an error like a wrong cvc or if the card is declined.

[bradlymcgregorhale]

Any news from the support team? On my side, the issue suddenly disappeared for successful transactions, but comes back when there an error like a wrong cvc or if the card is declined.

This is the same error we're seeing. A Laura from Wordline (Bambora) let us know that they'd be forwarding a request to have the SDK updated: https://capture.dropbox.com/49dKLAYvmJY2OMm9

I sent a follow up response in our open ticket with them, # 731671

[commercebuild]

From their support team:

Laura (Worldline)Dec 20, 2023, 09:49 PSTHi Bradly,Unfortunately I do not. I have requested the update but my guess is in 2024.thank youLaura
--

[dreamwerx]

Is this not embarrassing for this processing provider? There are plenty other out there- we are considering recommending to our clients to use another that has a up to date sdk. Also we hate using 'dev-master' SDK's - can't they generate a real release so we can lock versions?

[srosato]

@dreamwerx If a one liner fix takes years to merge in and is postponed to 2024, I have a hard time believing you'd get release tags. I had time to completely leave the PHP world and I still see this MR not being merged.

Hope they merge in, but at the end of the day it might just be easier to apply a patch with composer than waiting for them to fix that one liner!

[alexis-coulombe]

This repository is abandoned, yet is pinned on bambora's profile...

For anyone having this bug, fork and apply the fix from this PR.
Or check other people's fork HERE.