Add independent Pin to Dock feature and fix Save Logs to Desktop#153
Merged
Conversation
Resolves the two problems reported in issue #142: - Dock pinning is now its own feature, decoupled from Favorites. Adds a DockPinsManager store, Pin to Dock / Unpin from Dock commands on each location, a Docked tag, and repoints GetDockBands() at the dock-pin store. Existing favorites are migrated into dock pins once so current users keep their dock content. - Save Logs to Desktop now works. RollingFileLogger writes to a writable LocalApplicationData path instead of the read-only install directory, and SaveLogsCommand always produces a zip and shows a confirmation toast. Adds DockPinsManager tests, updates existing test callers and the README. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the two problems reported in #142.
Problem 1: No "Pin to Dock" option on a location
Dock bands were driven by the Favorites list, and there was no dedicated pin action on a location. The "Pin to Dock" the reporter saw was Command Palette's generic pin of the top-level launcher, not a per-city pin.
Fix: Dock pinning is now its own feature, decoupled from Favorites:
DockPinsManagerstore (own JSON file underLocalApplicationData\Microsoft.CmdPal), mirroringFavoritesManager.PinToDockCommand/UnpinFromDockCommandon every location, plus a "Docked" tag.GetDockBands()now reads from the dock-pin store instead of favorites.Problem 2: "Save Logs to Desktop" silently did nothing
On Store/MSIX installs the logger wrote to a read-only program folder, so
Directory.CreateDirectorythrew (swallowed), no logs were ever created, and the zip step was skipped.Fix:
RollingFileLoggerwrites to a writableLocalApplicationData\Microsoft.CmdPal\WeatherLogspath.SaveLogsCommandalways creates a zip (with a Desktop -> UserProfile fallback) and shows a confirmation toast.Testing
DockPinsManagerTests.WeatherListPageconstructor and refreshed the README.Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com