Fix media queries issue for the index / add fullscreen capability#31
Open
benoitchantre wants to merge 1 commit intobakerframework:masterfrom
Open
Fix media queries issue for the index / add fullscreen capability#31benoitchantre wants to merge 1 commit intobakerframework:masterfrom
benoitchantre wants to merge 1 commit intobakerframework:masterfrom
Conversation
|
I will try to take a look at this. I know there was some lengthy discussion on this on the prior board. My only concern is the double tap behavior to close. Since the other index requires just a single tap outside the index frame to close it. Will try to take a look. |
|
@feralbob We might want to discuss this as well. The only thing I don't like is the fact that it changes the tap/double tap behavior to dismiss the Index |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new extension parameter: -baker-index-fullscreen
It forces the index view to use the size of the screen instead of the size needed by its content.
That way, you can use media queries for the index. Reference: issue 637.
You can also design an index that is not visually fullscreen (with a transparent background).
The index can be closed with a double-tap.