Render media in max 4:3 proportions box#512
Closed
IBBoard wants to merge 6 commits intobaedert:masterfrom
Closed
Conversation
Keep 4:3 proportions where we can. Currently doesn't: * crop image height * middle-align the cropping * work correctly with multiple images
Images that are greater than app width and portrait are cropped correctly Images narrower than app width but portrait aren't cropped correctly Images that are small enough are okay Images that are wider than app width but not 4:3 tall have spacing
…ght place on hover
We now show the middle of the image Height is max 4:3 proportions of the widget
* Fix code formatting * Improve readability by extracting variable * Match change in 2b7d76
Contributor
Author
|
Out of date. Replaced by new branch with cherry-picking (#605) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My proposal to balance "I don't want tall images" with "I like media and run Corebird really wide" in Bug #465.
These changes make the visible part of the media render at max 4:3 proportions (chosen because they're old monitor proportions, fairly square and hence don't make you go "huh? what size/shape is that?", and still quite common for images based on what I saw in my timeline).
If the image is too wide then Corebird will scale the image (as it does now).
If the image is too tall then Corebird will show the middle of the image.
If the widget's bounding box is wider than the image then Corebird uses 4:3 proportions on the bounding box to calculate the max height, which will allow portrait images to show more height. (But if the image is landscape then the box won't grow too tall)