-
Notifications
You must be signed in to change notification settings - Fork 4
browser: add browser file system based on localStorage #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| import { BacktraceAttachment, BacktraceStringAttachment, FileSystem } from '@backtrace/sdk-core'; | ||
|
|
||
| const PREFIX = 'backtrace__'; | ||
|
|
||
| export class BrowserFileSystem implements FileSystem { | ||
| constructor(private readonly _storage = window.localStorage) {} | ||
|
|
||
| public async readDir(dir: string): Promise<string[]> { | ||
| return this.readDirSync(dir); | ||
| } | ||
|
|
||
| public readDirSync(dir: string): string[] { | ||
| dir = this.resolvePath(this.ensureTrailingSlash(dir)); | ||
|
|
||
| const result: string[] = []; | ||
| for (const key in this._storage) { | ||
| if (key.startsWith(dir)) { | ||
| result.push(key.substring(dir.length)); | ||
| } | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| public async createDir(_dir: string): Promise<void> { | ||
| return; | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| public createDirSync(_dir: string): void { | ||
| return; | ||
| } | ||
|
|
||
| public async readFile(path: string): Promise<string> { | ||
| return this.readFileSync(path); | ||
| } | ||
|
|
||
| public readFileSync(path: string): string { | ||
| const result = this._storage.getItem(this.resolvePath(path)); | ||
| if (!result) { | ||
| throw new Error('path does not exist'); | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| public async writeFile(path: string, content: string): Promise<void> { | ||
| return this.writeFileSync(path, content); | ||
| } | ||
|
|
||
| public writeFileSync(path: string, content: string): void { | ||
| this._storage.setItem(this.resolvePath(path), content); | ||
| } | ||
|
|
||
| public async unlink(path: string): Promise<void> { | ||
| return this.unlinkSync(path); | ||
| } | ||
|
|
||
| public unlinkSync(path: string): void { | ||
| this._storage.removeItem(this.resolvePath(path)); | ||
| } | ||
|
|
||
| public async exists(path: string): Promise<boolean> { | ||
| return this.existsSync(path); | ||
| } | ||
|
|
||
| public existsSync(path: string): boolean { | ||
| return this.resolvePath(path) in this._storage; | ||
| } | ||
|
|
||
| public createAttachment(path: string, name?: string): BacktraceAttachment { | ||
| return new BacktraceStringAttachment(name ?? this.basename(path), this.readFileSync(path)); | ||
| } | ||
|
|
||
| private resolvePath(key: string) { | ||
| return PREFIX + this.ensureLeadingSlash(key); | ||
| } | ||
|
|
||
| private basename(path: string) { | ||
| const lastSlashIndex = path.lastIndexOf('/'); | ||
| return lastSlashIndex === -1 ? path : path.substring(lastSlashIndex + 1); | ||
| } | ||
|
|
||
| private ensureLeadingSlash(path: string) { | ||
| if (path === '/') { | ||
| return '/'; | ||
| } | ||
|
|
||
| while (path.startsWith('/')) { | ||
| path = path.substring(1); | ||
| } | ||
|
|
||
| return '/' + path; | ||
| } | ||
|
|
||
| private ensureTrailingSlash(path: string) { | ||
| if (path === '/') { | ||
| return path; | ||
| } | ||
|
|
||
| while (path.endsWith('/')) { | ||
| path = path.substring(0, path.length - 1); | ||
| } | ||
|
|
||
| return path + '/'; | ||
| } | ||
| } | ||
174 changes: 174 additions & 0 deletions
174
packages/browser/tests/storage/BrowserFileSystem.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,174 @@ | ||
| import { BrowserFileSystem } from '../../src/storage/BrowserFileSystem.js'; | ||
|
|
||
| describe('BrowserFileSystem', () => { | ||
| beforeEach(() => { | ||
| localStorage.clear(); | ||
| }); | ||
|
|
||
| describe('readDir', () => { | ||
| it('should return all values in path', () => { | ||
| localStorage.setItem('backtrace__/dir/1', 'test'); | ||
| localStorage.setItem('backtrace__/dir/2', 'test'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| const files = fs.readDirSync('dir'); | ||
| expect(files).toEqual(['1', '2']); | ||
| }); | ||
|
|
||
| it('should return all values in absolute path', () => { | ||
| localStorage.setItem('backtrace__/dir1/dir2/1', 'test'); | ||
| localStorage.setItem('backtrace__/dir1/dir2/2', 'test'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| const files = fs.readDirSync('/dir1/dir2/'); | ||
| expect(files).toEqual(['1', '2']); | ||
| }); | ||
|
|
||
| it('should return no values for non-existing keys', () => { | ||
| const fs = new BrowserFileSystem(localStorage); | ||
| const files = fs.readDirSync('/dir1/dir2/'); | ||
| expect(files).toEqual([]); | ||
| }); | ||
|
|
||
| it('should not return values not prefixed by backtrace__', () => { | ||
| localStorage.setItem('test__/dir1/dir2/1', 'test'); | ||
| localStorage.setItem('backtrace__/dir1/dir2/2', 'test'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| const files = fs.readDirSync('/dir1/dir2/'); | ||
| expect(files).toEqual(['2']); | ||
| }); | ||
| }); | ||
|
|
||
| describe('createDir', () => { | ||
| it('should do nothing', () => { | ||
| localStorage.setItem('backtrace__/dir1/dir2/1', 'test'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| fs.createDirSync('/a/b/c'); | ||
|
|
||
| expect(Object.keys(localStorage)).toEqual(['backtrace__/dir1/dir2/1']); | ||
| }); | ||
| }); | ||
|
|
||
| describe('readFile', () => { | ||
| it('should return key contents', () => { | ||
| localStorage.setItem('backtrace__/dir1/dir2/1', 'test'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| const actual = fs.readFileSync('/dir1/dir2/1'); | ||
|
|
||
| expect(actual).toEqual('test'); | ||
| }); | ||
|
|
||
| it('should throw if key does not exist', () => { | ||
| const fs = new BrowserFileSystem(localStorage); | ||
| expect(() => fs.readFileSync('/dir1/dir2/1')).toThrow('path does not exist'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('writeFile', () => { | ||
| it('should write key contents', () => { | ||
| const fs = new BrowserFileSystem(localStorage); | ||
| fs.writeFileSync('/dir1/dir2/1', 'test'); | ||
|
|
||
| expect(localStorage.getItem('backtrace__/dir1/dir2/1')).toEqual('test'); | ||
| }); | ||
|
|
||
| it('should write key contents with relative path', () => { | ||
| const fs = new BrowserFileSystem(localStorage); | ||
| fs.writeFileSync('dir1/dir2/1', 'test'); | ||
|
|
||
| expect(localStorage.getItem('backtrace__/dir1/dir2/1')).toEqual('test'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('unlink', () => { | ||
| it('should remove file from storage', () => { | ||
| localStorage.setItem('backtrace__/dir1/dir2/1', 'test'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| fs.unlinkSync('/dir1/dir2/1'); | ||
|
|
||
| expect(localStorage.getItem('backtrace__/dir1/dir2/1')).toBeNull(); | ||
| }); | ||
|
|
||
| it('should remove file from storage with relative path', () => { | ||
| localStorage.setItem('backtrace__/dir1/dir2/1', 'test'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| fs.unlinkSync('dir1/dir2/1'); | ||
|
|
||
| expect(localStorage.getItem('backtrace__/dir1/dir2/1')).toBeNull(); | ||
| }); | ||
|
|
||
| it('should not throw if file does not exist', () => { | ||
| const fs = new BrowserFileSystem(localStorage); | ||
| expect(() => fs.unlinkSync('/dir1/dir2/1')).not.toThrow(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('existsSync', () => { | ||
| it('should return true if file exists', () => { | ||
| localStorage.setItem('backtrace__/dir1/dir2/1', 'test'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| const exists = fs.existsSync('/dir1/dir2/1'); | ||
|
|
||
| expect(exists).toBe(true); | ||
| }); | ||
|
|
||
| it('should return true if file exists wit relative path', () => { | ||
| localStorage.setItem('backtrace__/dir1/dir2/1', 'test'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| const exists = fs.existsSync('dir1/dir2/1'); | ||
|
|
||
| expect(exists).toBe(true); | ||
| }); | ||
|
|
||
| it('should return false if file does not exist', () => { | ||
| const fs = new BrowserFileSystem(localStorage); | ||
| const exists = fs.existsSync('/dir1/dir2/1'); | ||
|
|
||
| expect(exists).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe('createAttachment', () => { | ||
| it('should create attachment from file contents', () => { | ||
| localStorage.setItem('backtrace__/path/to/file.txt', 'file content'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| const attachment = fs.createAttachment('/path/to/file.txt'); | ||
|
|
||
| expect(attachment.name).toBe('file.txt'); | ||
| expect(attachment.get()).toBe('file content'); | ||
| }); | ||
|
|
||
| it('should create attachment from file contents with relative path', () => { | ||
| localStorage.setItem('backtrace__/path/to/file.txt', 'file content'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| const attachment = fs.createAttachment('path/to/file.txt'); | ||
|
|
||
| expect(attachment.name).toBe('file.txt'); | ||
| expect(attachment.get()).toBe('file content'); | ||
| }); | ||
|
|
||
| it('should create attachment with custom name', () => { | ||
| localStorage.setItem('backtrace__/path/to/file.txt', 'file content'); | ||
|
|
||
| const fs = new BrowserFileSystem(localStorage); | ||
| const attachment = fs.createAttachment('/path/to/file.txt', 'custom-name.txt'); | ||
|
|
||
| expect(attachment.name).toBe('custom-name.txt'); | ||
| expect(attachment.get()).toBe('file content'); | ||
| }); | ||
|
|
||
| it('should throw if file does not exist', () => { | ||
| const fs = new BrowserFileSystem(localStorage); | ||
| expect(() => fs.createAttachment('/nonexistent/file.txt')).toThrow('path does not exist'); | ||
| }); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.