sdk-core, electron: fix endless loop when loading SessionFiles#347
Merged
sdk-core, electron: fix endless loop when loading SessionFiles#347
Conversation
This was referenced Jun 27, 2025
Closed
Collaborator
konraddysput
left a comment
konraddysput
left a comment
There was a problem hiding this comment.
If someone already has session files - where do you handle a conversion from the old data model to the new one?
| interface FileSession { | ||
| readonly file: string; | ||
| readonly sessionId: string; | ||
| readonly sessionId: SessionId; |
Collaborator
There was a problem hiding this comment.
how about backward compatibility?
Contributor
Author
There was a problem hiding this comment.
You're right, this could fail. I added a check for this where required.
Contributor
Author
There's no conversion, the session ID is not used then, because it is not complete. |
perf2711
force-pushed
the
bugfix/session-id-timestamp
branch
from
8036415 to
1117d37
Compare
konraddysput
reviewed
Jul 2, 2025
konraddysput
approved these changes
Jul 2, 2025
This was referenced Jul 15, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two session file markers have the same ID, but different timestamp, it results in an endless loop.
This change prevents that by also using the timestamp as session ID.
This requires changes in Electron.