backtrace-android: add support for dynamic attachments#208
Merged
Conversation
Collaborator
|
Any need to stress/test adding attachments during minidump generation? If that’s already safe, this looks ready to land. |
melekr
reviewed
Mar 31, 2026
backtrace-library/src/main/java/backtraceio/library/base/BacktraceBase.java
Outdated
Show resolved
Hide resolved
melekr
approved these changes
Mar 31, 2026
…ashes Previously, crashpad, used for handling native crashes, did not support additional file attachments to the crash report context after initialization. Recent changes, however, have been made to the Backtrace fork of crashpad to allow this. The crashpad submodule reference has been updated in this commit to point to this change. This commit adds support for adding file attachments after initialization to native crash reports. The changes follow the existing pattern for adding attributes dynamically which forward the request to the crashpad backend in response to a call to `addAttachment` on the Backtrace client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, crashpad, used for handling native crashes, did not support additional file attachments to the crash report context after initialization. Recent changes, however, have been made to the Backtrace fork of crashpad to allow this. The crashpad submodule reference has been updated in this commit to point to this change.
This commit adds support for adding file attachments after initialization to native crash reports.
The changes follow the existing pattern for adding attributes dynamically which forward the request to the crashpad backend in response to a call to
addAttachmenton the Backtrace client.