chore(quay): add e2e tests for multiinstance#9104
Merged
Merged
Conversation
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
dzemanov
requested review from
a team,
CryptoRodeo,
Eswaraiahsapram,
HusneShabbir,
caugello,
christoph-jerolimov,
ciiay,
debsmita1,
divyanshiGupta,
djanickova,
its-mitesh-kumar,
jrichter1,
karthikjeeyar,
lokanandaprabhu and
rohitkrai03
as code owners
Contributor
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Quay multi-instance coverage across the plugin’s dev app, e2e suite, and unit tests to validate instance selection behavior and error handling (RHIDP-9428).
Changes:
- Added a new dev app route (
/quay/multi-instance) backed by a mock entity annotated with a non-default Quay instance. - Added Playwright e2e coverage to verify multi-instance affects both repository URL generation and returned tag/security-scan data.
- Expanded unit test coverage for multi-instance configuration validation and “unknown instance” error handling in hooks and API client.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| workspaces/quay/plugins/quay/tests/quay.spec.ts | Adds an e2e test validating multi-instance routing, URL, and data differences |
| workspaces/quay/plugins/quay/src/hooks/useTags.test.ts | Adds hook test coverage for unknown instance failure behavior |
| workspaces/quay/plugins/quay/src/hooks/useRepository.test.ts | Expands coverage for missing instance annotation handling |
| workspaces/quay/plugins/quay/src/components/useQuayAppData.test.ts | Adds coverage for optional instance annotation parsing |
| workspaces/quay/plugins/quay/src/components/QuayRepository/QuayRepository.test.tsx | Verifies title-link behavior based on presence/absence of instance UI URL |
| workspaces/quay/plugins/quay/src/api/index.test.ts | Adds validation tests for mixed configs and unknown instance requests |
| workspaces/quay/plugins/quay/src/api/index.backend.test.ts | Adds backend test for unknown instance request behavior |
| workspaces/quay/plugins/quay/dev/index.tsx | Adds dev app “Multi-instance” page and enhances mock API behavior for instance-aware responses |
| workspaces/quay/plugins/quay/dev/data/security_vulnerabilities.ts | Introduces digest→security-details mapping used by the dev mock |
| workspaces/quay/plugins/quay/dev/data/entity.ts | Adds mock entities for default + non-default (devel) instance scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Adds e2e tests for Quay multiinstance.
Adds 1 new page to dev app: Multi-instance.
Adds more unit tests for multi-instance cases.
Fixes
Fixes https://redhat.atlassian.net/browse/RHIDP-9428
✔️ Checklist
Signed-off-byline in the message. (more info)