Add the ability to auto close the tab on approval#128
Open
senxd wants to merge 1 commit intobacknotprop:mainfrom
Open
Add the ability to auto close the tab on approval#128senxd wants to merge 1 commit intobacknotprop:mainfrom
senxd wants to merge 1 commit intobacknotprop:mainfrom
Conversation
|
Looks great! Could you share some screenshots of this feature? It would be much easier to understand. |
Author
recording.movHere is a video. By default, it is toggled off, and nothing is changed. When enabled, it closes the tab once you approve/send feedback. It just helps with tab clutter as I close it regardless. |
Owner
|
Big feature. Taking a look. I just got back from my only vacation this year and will get these PRs going. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When approving/sending feedback, the default behavior is to show a full-page indicator. I have added an option in the settings to close the tab after submitting instead.