fix(opencode): OpenChamber submit_plan hang#1004
Draft
basicsharp wants to merge 1 commit into
Draft
Conversation
64116ce to
e75be92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue background
OpenChamber runs the OpenCode server inside the desktop app process and marks that environment with
OPENCHAMBER_RUNTIME. In that host, a long-runningsubmit_plantool call is a poor fit: OpenChamber keeps the tool part in a running state while Plannotator waits for the user to approve or comment in the browser UI.This was observed with
@plannotator/opencodein OpenChamber: the plan backing file was written successfully and the Plannotator UI could be launched, but the OpenChamber chat stayed stuck around thesubmit_plantool call. The same flow worked from the normal OpenCode CLI because the CLI can tolerate the blocking approval flow.The first attempted workaround was to return the review URL immediately from OpenChamber mode. That fixed the visible hang, but it also broke the plan-review gate: OpenChamber no longer waited for the eventual approval, denial comments, or helper failure. This PR keeps the immediate URL return while preserving the review result path.
Summary
OPENCHAMBER_RUNTIMEin the OpenCode pluginBehavior after this change
submit_planagain with targeted editssubmit_planbehaviorValidation