Skip to content

Conversation

@docwilmot
Copy link
Contributor

Fixes #947

@jenlampton
Copy link
Member

Is there alread a core issue open for the change to www/core/modules/installer/installer.browser.inc?

If so, we need to add that into PATCHES.md as a part of this PR so that future core updates won't revert this change.

@docwilmot
Copy link
Contributor Author

Should I have the change to www/core/modules/installer/installer.browser.inc in both a core PR and this PR? Or only in the core PR?

@docwilmot
Copy link
Contributor Author

Core PR at backdrop/backdrop#5188
Associated issue: backdrop/backdrop-issues#5845

@jenlampton
Copy link
Member

jenlampton commented Jan 6, 2026

Thanks @docwilmot !

In this PR, can you add an update to the PATCHES.txt file that contains those two links? It would go in the core section and look something like...

 - Installer module - increase query count
    https://github.com/backdrop/backdrop-issues/issues/5845
    https://github.com/backdrop/backdrop/pull/5188.patch

This is so that the next time someone updates core for b.org, they will see that a core patch needs to be applied, and (hopefully) also revisit the core issue to help move it along :) Its a good policy for both the b.org site, and the whole Backdrop community!

@docwilmot
Copy link
Contributor Author

Thanks @docwilmot !

In this PR, can you add an update to the PATCHES.txt file that contains those two links? It would go in the core section and look something like...

 - Installer module - increase query count
    https://github.com/backdrop/backdrop-issues/issues/5845
    https://github.com/backdrop/backdrop/pull/5188.patch

This is so that the next time someone updates core for b.org, they will see that a core patch needs to be applied, and (hopefully) also revisit the core issue to help move it along :) Its a good policy for both the b.org site, and the whole Backdrop community!

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow modules to query for all projects, optionally of a certain type.

2 participants