Open
Conversation
Adding note about Google Analytics module.
Linking to wiki instead of listing known issues in README.
Contributor
|
Can we add link to Wiki pages https://github.com/backdrop-contrib/d2b_migrate/wiki in Readme file on this same PR? @stpaultim ? |
Member
Author
|
@irinaz This PR already adds a link to the Wiki, but it is a specific page in the Wiki. I think you are suggesting a general link to the wiki, which I do think makes sense. I'm revising the PR now. |
Member
Author
|
@irinaz How does this look? https://github.com/stpaultim/d2b_migrate/tree/google-analytics-note |
Member
Author
|
Atten: @docwilmot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #50
Fixes: #48