fix(security): bump Go toolchain to 1.26.4, add govulncheck pre-commit hook#37
Merged
Conversation
…t hook GO-2026-5039 (net/textproto) and GO-2026-5037 (crypto/x509) are reachable from proxy.redirectFollowingTransport / mustLogger and fixed in go1.26.4 — CI govulncheck fails on every branch since publication. The go directive stays at 1.26.3 so golangci-lint's isolated pre-commit env (GOTOOLCHAIN=local) can still load packages; the toolchain directive upgrades actual builds and CI (setup-go reads go-version-file: go.mod). The new local govulncheck hook surfaces future CVEs at commit time instead of in CI (requires golang.org/x/vuln/cmd/govulncheck).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI
govulncheckfails on every branch (including master) since publication of:proxy.redirectFollowingTransport.RoundTripmustLoggerBoth fixed in go1.26.4.
What
go.mod:toolchain go1.26.4(thegodirective stays 1.26.3 so golangci-lint's isolated pre-commit env withGOTOOLCHAIN=localkeeps loading packages; CI'ssetup-goreadsgo-version-file: go.modand picks the toolchain up).pre-commit-config.yaml: localgovulncheck ./...hook — future CVEs surface at commit time instead of in CI (requiresgo install golang.org/x/vuln/cmd/govulncheck@latest)govulncheck ./...on this branch: 0 vulnerabilities affecting the code.Unblocks #36 (will be rebased on top once this merges).