Fix Build CI: fetch libilbc submodule before Docker build#158
Merged
tinpotnick merged 2 commits intoJun 9, 2026
Merged
Conversation
The Build workflow checks out without `submodules: recursive`, so `libilbc/` is empty in the Docker build context. The Dockerfile's `COPY libilbc/ /src/libilbc/` copies an empty dir, cmake finds no CMakeLists.txt, libilbc.so.3 is never built, and the Rust cdylib fails to link (`ld: cannot find -l:libilbc.so.3`). Fetch the submodule at checkout so the build context contains the libilbc source. rust.yml already does this. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tinpotnick
approved these changes
Jun 9, 2026
…ule-checkout # Conflicts: # .github/workflows/buildimage.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Build workflow (
buildimage.yaml) has been failing on every push tomainfor weeks. The Docker build dies at the cmake step:Root cause
libilbcis a git submodule (.gitmodules:path = libilbc,url = https://github.com/TimothyGu/libilbc). The Dockerfile doesCOPY libilbc/ /src/libilbc/and runs cmake on it to buildlibilbc.so.3.The checkout step used
actions/checkout@v5with nosubmodules:setting.actions/checkoutdoes not fetch submodules by default (any version), solibilbc/is empty in the build context → cmake finds noCMakeLists.txt→libilbc.so.3is never built → the Rust cdylib fails to link.Fix
Add
submodules: recursiveto the checkout step so the build context contains the libilbc source.rust.ymlalready does this. The submodule is a public repo, so no extra token is needed.This is independent of the rustfmt drift failing the Rust CI job (handled in a separate PR), and is not related to the action-version-bump PRs —
checkout@v5and@v6both skip submodules by default.🤖 Generated with Claude Code