Harden qr init secret handling and config recovery#45
Conversation
Co-authored-by: Aanish Bhirud <baanish@users.noreply.github.com>
|
Warning Review limit reached
Next review available in: 3 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (6)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Previous Review Summary (commit d27b0fd)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d27b0fd)Status: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by glm-5.2-short · Input: 18.5K · Output: 3.2K · Cached: 152.1K |
- Parse config.toml without QR_* overrides when deciding if init should recreate - Fail clearly on invalid env overrides instead of treating them as corrupt config - Prefix keychain accounts with primary/fallback role; legacy lookup for primary - Add tests for invalid-env init behavior and shared-default-env keychain storage Co-authored-by: Aanish Bhirud <baanish@users.noreply.github.com>
Summary
Makes
qr initsafe to rerun after corrupt/partial config and avoids writing API keys insecurely toconfig.toml.qr initbeforeAppConfig::load()so a broken config cannot block recoveryatomic::write_private()for Unix0600config creation from the first byteTest plan
cargo testcargo fmt --all -- --checkcargo clippy --all-targets --locked -- -D warnings