Skip to content

chore(do): update codex/claude agent defaults for auto modes#41

Merged
baanish merged 3 commits into
masterfrom
chore/update-agent-auto-modes
Jul 1, 2026
Merged

chore(do): update codex/claude agent defaults for auto modes#41
baanish merged 3 commits into
masterfrom
chore/update-agent-auto-modes

Conversation

@baanish

@baanish baanish commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Update do.agents.codex default to use --sandbox workspace-write, --ask-for-approval on-request, and approvals_reviewer=auto_review.
  • Update do.agents.claude default to use --permission-mode auto -p.
  • Refresh PRD examples to match.

Test plan

  • cargo test

Made with Cursor

Summary by CodeRabbit

  • Documentation
    • Updated the PRD guidance and TOML examples for agent delegation commands, including the updated Codex and Claude invocation patterns.
    • Clarified the recommended default setup for Codex sandbox/approval behavior and Claude permission handling.
  • Chores
    • Improved default agent command safety by switching to automated permission mode and adding sandbox/approval-oriented Codex defaults.
    • Added automatic migration of legacy default commands when loading/saving configuration, preserving any custom command overrides.

Use Codex auto-review approval flow and Claude auto permission mode in default agent suggestions.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@baanish, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: 7744f448-cab5-47a5-adab-ab21d7069edc

📥 Commits

Reviewing files that changed from the base of the PR and between 488088f and 1d90f35.

📒 Files selected for processing (1)
  • src/config.rs
📝 Walkthrough

Walkthrough

Default Codex and Claude command strings are updated in source defaults, the shipped TOML config, and PRD examples. Config loading also rewrites legacy persisted agent commands in config.toml to the current defaults.

Changes

Agent default command updates

Layer / File(s) Summary
Legacy default migration
src/config.rs
AppConfig::load_from_env_with_path now calls migration logic that detects legacy [do.agents] codex and claude values, rewrites matching TOML entries, and persists the file only when changes are made; tests cover legacy rewriting and custom codex preservation.
Rust and TOML defaults
src/config.rs, config/default.toml
default_codex_agent() and default_claude_agent() return the updated command strings, and config/default.toml is aligned to the same codex and claude defaults.
PRD examples
PRD.md
The delegate example and delegate agent config snippet are updated to show the new Codex sandbox/approval command and the Claude permission-mode auto command.

Estimated code review effort: 4 (Complex) | ~45 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands.

@kilo-code-bot

kilo-code-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The previously raised P2 (legacy [do.agents] defaults not being migrated on upgrade) is now resolved: the new migrate_legacy_agent_defaults rewrites the exact legacy codex/claude values to the new shipped defaults in any existing config.toml on load, while preserving custom user overrides.

Files Reviewed (1 file)
  • src/config.rs - incremental migration logic for legacy agent defaults
Previous Review Summary (commit 22760cd)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 22760cd)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • PRD.md
  • config/default.toml
  • src/config.rs

Reviewed by glm-5.2-short · Input: 27.6K · Output: 3.6K · Cached: 120.4K

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22760cd648

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/config.rs
@baanish baanish closed this Jul 1, 2026
@baanish baanish reopened this Jul 1, 2026
baanish and others added 2 commits July 1, 2026 19:50
Rewrite shipped codex/claude agent commands to the new auto-mode defaults when config.toml still contains the previous template values.

Co-authored-by: Cursor <cursoragent@cursor.com>
Integrate load_file_without_env refactor and run legacy agent-default migration from that path.

Co-authored-by: Cursor <cursoragent@cursor.com>
@baanish

baanish commented Jul 1, 2026

Copy link
Copy Markdown
Owner Author

Addressed the legacy-default migration feedback in 488088f: on load, configs that still have the shipped codex exec / claude --dangerously-skip-permissions -p values are rewritten to the new auto-mode defaults (custom values are left untouched). Integrated with master's load_file_without_env in 1d90f35.

@baanish baanish merged commit cd6ff3c into master Jul 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant