Skip to content

Conversation

@linkdotnet
Copy link
Collaborator

Added FindByRole and FindAllByRole to bunit.web.query.

Copy link
Member

@egil egil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance, this looks good. I a wondering if the new extension types can be leverage here to get extension properties instead of extension methods only.

@linkdotnet
Copy link
Collaborator Author

Good thinking - but should we move this to v3 and align with FindByLabel? Otherwise we break our API style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants