Dev best practices#3
Open
slippycheeze wants to merge 1 commit intob20n:banjiewenfrom
slippycheeze:dev-best-practices
Open
Dev best practices#3slippycheeze wants to merge 1 commit intob20n:banjiewenfrom slippycheeze:dev-best-practices
slippycheeze wants to merge 1 commit intob20n:banjiewenfrom
slippycheeze:dev-best-practices
Conversation
Now that the leinengein plugin system works, best practice is to install the `swank-clojure` and `lein-clojars` tools through the plugin system. Having them as dev dependencies is not just deprecated, it can actively break some functionality; this includes the modern `clojure-jack-in` facility in `clojure-mode`. Signed-off-by: Daniel Pittman <daniel@rimspace.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the leinengein plugin system works, best practice is to install the
swank-clojureandlein-clojarstools through the plugin system.Having them as dev dependencies is not just deprecated, it can actively break
some functionality; this includes the modern
clojure-jack-infacility inclojure-mode.Signed-off-by: Daniel Pittman daniel@rimspace.net