[codex] Add Codex map-efficient skill#151
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Codex provider scaffolding so Codex skills are discovered from the official .agents/skills root (instead of .codex/skills), adds the new Codex-native $map-efficient execution skill (with a supporting reference), and updates template syncing, provider installation paths, docs, SkillIR, and guardrail tests to match.
Changes:
- Move Codex skill source-of-truth to
.agents/skillsand update template sync + init/install paths accordingly. - Add the new
$map-efficientCodex execution skill andefficient-reference.md, and wire it into docs and tests. - Update MAP mutation-boundary filtering to ignore
.agents/(like.codex/and.map/) when computing changed files.
Reviewed changes
Copilot reviewed 24 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_template_sync.py | Update Codex template sync assertions to compare .agents/skills/* (and .codex/*) against templates/codex/*. |
| tests/test_skills.py | Extend Codex mutation-boundary surface coverage to include map-efficient; minor cleanup. |
| tests/test_skill_ir.py | Ensure SkillIR audit expects the new map-efficient skill among shipped Codex skills. |
| tests/test_mapify_cli.py | Update Codex init/install acceptance checks to expect .agents/skills and verify $map-efficient documentation/markers. |
| src/mapify_cli/templates/map/scripts/map_step_runner.py | Exclude .agents/ from mutation-boundary changed-file detection to avoid false positives. |
| src/mapify_cli/templates/map/scripts/map_orchestrator.py | Remove unused noqa annotations on dynamic imports (template script). |
| src/mapify_cli/templates/codex/skills/map-plan/SKILL.md | Refresh description and add $map-efficient to related skills. |
| src/mapify_cli/templates/codex/skills/map-efficient/SKILL.md | Add Codex-native MAP execution skill documenting state-machine workflow and required commands. |
| src/mapify_cli/templates/codex/skills/map-efficient/efficient-reference.md | Add supporting reference for $map-efficient (gates, waves, TDD, retry loop, commit policy). |
| src/mapify_cli/templates/codex/AGENTS.md | Document .agents/skills location and add $map-efficient to available skills. |
| src/mapify_cli/skill_ir.py | Treat .agents roots as codex provider for SkillIR auditing. |
| src/mapify_cli/delivery/providers.py | Update Codex provider docstring to reflect .agents/.codex install surface. |
| src/mapify_cli/delivery/codex_copier.py | Install Codex skills into .agents/skills instead of .codex/skills. |
| src/mapify_cli/init.py | Update init/doctor/is_map_initialized messaging and checks for .agents/skills in Codex layout. |
| scripts/sync-templates.sh | Sync .agents/skills into templates/codex/skills and keep syncing .codex/* alongside it. |
| README.md | Update Codex init output documentation to reflect .agents/skills creation. |
| docs/USAGE.md | Update Codex layout documentation and list $map-efficient as part of installed skills. |
| docs/ARCHITECTURE.md | Update provider portability + directory layout docs for .agents/skills + .codex/ config split. |
| .map/scripts/map_step_runner.py | Mirror template change to ignore .agents/ in changed-file/mutation-boundary logic. |
| .map/scripts/map_orchestrator.py | Mirror template change removing unused noqa annotations on dynamic imports. |
| .codex/AGENTS.md | Mirror template doc updates: .agents/skills location and $map-efficient listing. |
| .agents/skills/map-plan/SKILL.md | Move Codex map-plan skill into .agents/skills and align content with shipped template. |
| .agents/skills/map-fast/SKILL.md | Add/move Codex map-fast skill into .agents/skills for discovery and template sync. |
| .agents/skills/map-explain/SKILL.md | Add/move Codex map-explain skill into .agents/skills for discovery and template sync. |
| .agents/skills/map-efficient/SKILL.md | Add .agents source-of-truth copy of the new $map-efficient skill for template sync. |
| .agents/skills/map-efficient/efficient-reference.md | Add .agents source-of-truth supporting reference for $map-efficient. |
| .agents/skills/map-check/SKILL.md | Add/move Codex map-check skill into .agents/skills for discovery and template sync. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.codex/skillsto the official.agents/skillsdiscovery root.$map-efficientskill and supporting reference file.Validation
make checkquick_validate.pyfor Codex skills under.agents/skillscodex debug prompt-inputshows the project.agents/skillsroot andmap-framework:map-efficient