chore: rename repo URLs ayhammouda/python-docs-mcp-server -> python-stdlib-mcp#26
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR renames the MCP server from ChangesRepository Rename
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/RELEASE.md (1)
54-54: 💤 Low valueConsider replacing the
<owner>placeholder withayhammouda.The URLs currently use
<owner>as a placeholder. Since this is release documentation for a specific project (not a reusable template), replacing it with the actual owner nameayhammoudawould make these URLs directly clickable and more convenient to use.📝 Example fix for line 54
- https://github.com/<owner>/python-stdlib-mcp/actions/workflows/release.yml + https://github.com/ayhammouda/python-stdlib-mcp/actions/workflows/release.ymlApply the same pattern to lines 79 and 121.
Also applies to: 79-79, 121-121
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/RELEASE.md at line 54, Replace the generic <owner> placeholder with the actual GitHub owner "ayhammouda" in the release URLs (the occurrences shown in the diff, e.g., the workflow URL and the other two instances referenced at lines 79 and 121) so the links become concrete and clickable; update each URL string that contains "<owner>" to use "ayhammouda" instead.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/RELEASE.md:
- Line 54: Replace the generic <owner> placeholder with the actual GitHub owner
"ayhammouda" in the release URLs (the occurrences shown in the diff, e.g., the
workflow URL and the other two instances referenced at lines 79 and 121) so the
links become concrete and clickable; update each URL string that contains
"<owner>" to use "ayhammouda" instead.
…on-stdlib-mcp Per CR decision 9.2 (locked 2026-05-14). PyPI package name unchanged. GitHub auto-redirects old URL to new for clone/fetch.
PR #2 review surfaced two `Repository: python-docs-mcp-server` references in the PyPI Trusted Publishing setup checklists (RELEASE.md lines 11 and 99). These refer to the GitHub repo name used for OIDC token issuance — must match the post-rename `python-stdlib-mcp` or Trusted Publishing will fail at v0.1.5 tag time. PyPI project name (line 9 and 97) stays `python-docs-mcp-server` — the PyPI package name is unchanged.
96f1315 to
be49bdb
Compare
Owner decision 2026-05-14: keep python-docs-mcp-server name on GitHub and PyPI. Reverts PR #26 in-repo URL rename + updates ROADMAP.md to drop the rename workstream. Positioning, PyPI Trusted Publisher config, phase backlog all unchanged.
Summary
PR #2 of 6 in the v0.1.5 launch wave (per CHANGE-REQUEST-v0.1.5-launch.md, §F).
In-repo URL rename to prepare for the GitHub repo rename (
python-docs-mcp-server→python-stdlib-mcp, locked decision §9.2). The PyPI package name stayspython-docs-mcp-serverthrough v0.1.5 to avoid stacking two rename migrations.Surface area
3 files, 24+/24-:
README.md— 16 URL refs (CI/Security/CodeQL badges, OpenSSF Scorecard, Glama badge, MCP Registry badge, mcp-name comment, install scaffolds + MCP client config snippets across all PRE-PYPI fenced blocks)server.json— 3 fields (name,websiteUrl,repository.url);identifier(PyPI name) unchanged.github/RELEASE.md— 3<owner>/python-docs-mcp-servertemplate URLs + 1 regex-literal pattern in the PRE-PYPI scaffolding validation scriptWhat stays unchanged (audit confirmed)
pyproject.tomlname = "python-docs-mcp-server"(PyPI package name)server.json"identifier": "python-docs-mcp-server"(PyPI registry identifier)uvx python-docs-mcp-serverandpipx install python-docs-mcp-serverCLI invocations in README, CONTRIBUTING, RELEASE, INTEGRATION-TESTsrc/andtests/are untouchedHard sequencing
This PR must merge before tagging v0.1.5 (per plan critical path
F6 → B5); otherwise the release artifacts and PyPI metadata will reference the now-redirected old repo URL. The GitHub redirect handlesgit clone, but the canonical metadata in PyPI/MCP Registry should point at the new URL from v0.1.5's first publish.Manual follow-ups (post-merge, not in this PR)
python-stdlib-mcp(F3).github/workflows/scorecard.yml)Conflict expectations
Touches the same README region as apps#25 (positioning). A small rebase will be needed when the second of these merges. Both changes are surgical to different lines/substrings so conflicts are mechanical.
Test plan
git grep 'ayhammouda/python-docs-mcp-server'returns 0 matchesgit grep 'io.github.ayhammouda%2Fpython-docs-mcp-server'returns 0 matchesname = "python-docs-mcp-server"in pyproject.toml;"identifier": "python-docs-mcp-server"in server.jsonserver.jsonparses as valid JSON🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Chores