feat: add Shift+wheel horizontal scroll for wide tables#24
Merged
Conversation
Restores the wheel-to-x table-scroll ergonomic from issue #4 but gates it on the Shift modifier, so plain wheel still scrolls the document (#22) while Shift+wheel becomes the explicit opt-in for sideways table scrolling. `forward_shift_wheel_to_horizontal_scroll` mirrors the previously-removed helper (PR #23) with one extra early-return on `modifiers.shift`. Edge pass-through is preserved so Shift+wheel at the table's left/right edge keeps moving the page. Docs updated: KEYBOARD_SHORTCUTS, ARCHITECTURE, TARGET_METRICS, LESSONS, devlog 033.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #23 removed
forward_wheel_to_horizontal_scrollto fix #22 (cursor-over-table nudging wide tables sideways during normal document scrolling). That also reverted the issue #4 ergonomic — wide-table horizontal scroll regressed to "grab the bottom scrollbar" only.This change reintroduces the wheel→x redirect but gates it on the Shift modifier, so:
Shift matches the browser convention for horizontal scroll and doesn't collide with anything else in the doc scroller (Ctrl is already taken by zoom).
Changes
forward_shift_wheel_to_horizontal_scrollincrates/egui_commonmark/.../pulldown.rs— identical edge-passthrough logic to the prior helper, plus amodifiers.shiftearly-return.ScrollAreaOutput.Test plan
cargo fmt --check— cleancargo check— clean (two pre-existing warnings unrelated to this change)cargo clippy --all-targets— clean (same pre-existing warnings)Note: the egui MCP bridge has no keystroke/modifier injection so Shift+wheel behavior can't be E2E-tested via Xvfb. Manual verification on real display required before merge.
Refs #4, #22, #23.