PHP 8.1 Compatibility#7
Merged
Merged
Conversation
Member
|
@SychO9 hello! thanx! But why you changed version of axy/codecs-base64vlq to 2.0? |
Contributor
Author
|
Thank you for looking into this! I forgot to push another PR to codecs, the package also uses axy/errors and since axy/sourcemap requires codecs they would clash so codecs would also need a new version that uses axy/errors 3.0 (https://github.com/axypro/codecs-base64vlq/blob/master/composer.json#L22) |
Contributor
Author
|
Opened the PR: axypro/codecs-base64vlq#1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! thanks for the package!
This PR updates the code to be able to support newer versions of PHP, as of right now while the package works, there are deprecation warnings in PHP 8.1
Updated code is:
Tests to use phpunit 9.0
Source code to use correct return types of implemented interfaces, and use
__serialize()and__unserialize()asserialize()andunserialize()are deprecated.Should I remove the GitHub actions workflow file? I see there is Travis CI used but I left it just in case.
I moved the source files into a
srcfolder as I was having trouble running tests.This PR alone doesn't work, it requires
axy/errorsto also be updated (axypro/errors#4) and a major version released as it completely renames a class.