Conversation
Collaborator
Author
|
/clang-format |
2 similar comments
Collaborator
Author
|
/clang-format |
Collaborator
Author
|
/clang-format |
Collaborator
Author
|
/clang-format |
73c8376 to
0f7f436
Compare
Collaborator
Author
|
/clang-format |
Collaborator
Author
|
/clang-format |
Collaborator
Author
|
/clang-format |
Collaborator
Author
|
/clang-format |
Collaborator
Author
|
/clang-format |
Collaborator
Author
|
/clang-format |
Collaborator
Author
|
/clang-format |
Collaborator
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86a86e064d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
Author
|
/clang-format |
Collaborator
Author
|
/clang-format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested Device and RHIs
Windows: D3D11, D3D12, Vulkan with
DP E4 PCVRdeviceDescribe your changes
AX_ENABLE_OPENXR, gated byAX_ENABLE_VRand disabled by default.release-1.1.60) to the 1kiss dependency profile and third-party CMake integration.OpenXRDriver, a long-lived runtime backend that owns OpenXR instance, system, session, local space, stereo swapchains, frame timing, action sets, interaction profiles, and controller state.VRSceneCompositor, the product VR rendering path backed by OpenXR. It polls XR frame/input state before scheduler update, renders each eye into the runtime swapchain, draws controller rays, submits projection layers, and falls back to normal rendering when the XR session is unavailable.SceneRendererabstraction withSceneCompositor, now owned byRenderViewCore. Custom scene composition is installed withRenderViewCore::setSceneCompositor().VRGenericRendererwithVRPreviewSceneCompositorfor non-runtime stereo preview and debugging. The preview path keeps side-by-side rendering, distortion meshes, head tracking, render scale, vignette, and VR scissor remapping.XRInputEventandXRInputEventListener, covering controller buttons, thumbstick axes, aim poses, grip poses, hand, phase, value, and interaction profile data.PointerType::Controller, optional 3D rays, previous rays, andPointerHitResult, allowing XR controller rays to drive existing pointer-based UI and scene interactions.InputSystem, including controller pointer down/move/up/scroll and XR input event dispatch.EventDispatcherto route XR input listeners and store pointer hit results during scene-graph hit testing and pointer capture dispatch.Node::onPointerHitTest()public and ray-aware, so custom 2D/3D nodes can participate in controller-ray picking.Widget,ScrollView, GUI scroll views, menus, and terrain picking to support controller rays, hit results, clipping, scroll gestures, and captured pointer streams in VR.Mat4::createPerspectiveOffCenter(), used for per-eye OpenXR frusta.RenderTexturePassso it can target an RHIRenderTargetdirectly, disable camera override for advanced compositors, and use stable begin/clear/end ordering.ExternalTextureDescandDriverBase::createTextureFromNativeHandle().RenderContext::submitCurrentFrameCommands()andRenderer::submitCurrentFrameCommands()so external runtimes can receive completed rendering work before swapchain release.VulkanInteropabstraction layer.OpenXRVulkanInteropimplements the interface and is registered viaApplication::registerVulkanInterop().GraphicsCorequeries runtime-required Vulkan instance/device extensions and the runtime-selected physical device through this interface, keeping the core RHI free of OpenXR dependencies.DriverContexttoGraphicsCore.VRPreviewSceneCompositororVRSceneCompositorinstead ofVRGenericRenderer.Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR