Update freetype to 2.14.3-c39ca391 for resolve hvfload issue#3158
Draft
halx99 wants to merge 1 commit into
Draft
Update freetype to 2.14.3-c39ca391 for resolve hvfload issue#3158halx99 wants to merge 1 commit into
halx99 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates FreeType to version 2.14.3-c39ca391 and introduces several significant improvements and bug fixes. Key changes include the implementation of dynamic memory allocation for render pools in both the black-and-white and smooth rasterizers to handle complex glyphs, refactored glyph blending and metrics calculation logic (especially for the HVF module), and enhanced stack safety and overflow checks in the PostScript and TrueType interpreters. Review feedback identified several instances where memory allocation results from FT_QNEW_ARRAY were not correctly captured, which would lead to uninitialized variable usage or incorrect success returns upon allocation failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR