Skip to content

Update freetype to 2.14.3-c39ca391 for resolve hvfload issue#3158

Draft
halx99 wants to merge 1 commit into
devfrom
update-freetype
Draft

Update freetype to 2.14.3-c39ca391 for resolve hvfload issue#3158
halx99 wants to merge 1 commit into
devfrom
update-freetype

Conversation

@halx99
Copy link
Copy Markdown
Collaborator

@halx99 halx99 commented May 13, 2026

Describe your changes

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates FreeType to version 2.14.3-c39ca391 and introduces several significant improvements and bug fixes. Key changes include the implementation of dynamic memory allocation for render pools in both the black-and-white and smooth rasterizers to handle complex glyphs, refactored glyph blending and metrics calculation logic (especially for the HVF module), and enhanced stack safety and overflow checks in the PostScript and TrueType interpreters. Review feedback identified several instances where memory allocation results from FT_QNEW_ARRAY were not correctly captured, which would lead to uninitialized variable usage or incorrect success returns upon allocation failure.

Comment thread 3rdparty/freetype/src/raster/ftraster.c
Comment thread 3rdparty/freetype/src/smooth/ftgrays.c
Comment thread 3rdparty/freetype/src/hvf/hvfobjs.c
@halx99 halx99 added this to the 3.0.0 milestone May 13, 2026
@halx99 halx99 added the enhancement New feature or request label May 13, 2026
@halx99 halx99 marked this pull request as draft May 13, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant