Conversation
Collaborator
xopok
commented
May 23, 2020
xopok
commented
This might not cover all possible watch screens (e.g. FR920 does have a rectangular one) but for now it's the easiest I could come up with.
Also prepend @Strings. to titles, the opportunity for i18n.
…d sizes. Only draws the chart if for: - Edge devices and square watches: - the datafield height is at least 1/3 of the screen height. - Round and semi-round watches: - the datafield is the middle one in the 3A layout (then also displays the cadence). Alternative font is now an option only for layouts allowing the chart.
(hot fix)
axl13
reviewed
Jun 1, 2020
| <label id="value" x="center" y="center" | ||
| font="Graphics.FONT_SYSTEM_NUMBER_THAI_HOT" | ||
| justification="Graphics.TEXT_JUSTIFY_CENTER"/> | ||
| <label id="mark" x="center" y="top" |
axl13
reviewed
Jun 1, 2020
| setLayout(Rez.Layouts.PowerFieldLayout(dc)); | ||
| } | ||
|
|
||
| function drawZones(dc, zone, power) { |
Owner
There was a problem hiding this comment.
I'd prefer to keep the old functionality with the color indicator (it's easier to see which zone you in the interval), on top on ability to change to the Graph (in options) if one prefers.
axl13
reviewed
Jun 1, 2020
Owner
axl13
left a comment
axl13
left a comment
There was a problem hiding this comment.
Please keep the old way of coloring zones in the options. Thanks!
Co-authored-by: Oleksiy Mishchenko <amishchenko@gmail.com>
Otherwise `dc_hight.toFloach` gonna checkout at line 163, if Layout is not initialized (which is the case on Edge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.