Skip to content

Fixed basestring NameError in Python3#37

Closed
ulikoehler wants to merge 1 commit intoaxiak:masterfrom
ulikoehler:basestring
Closed

Fixed basestring NameError in Python3#37
ulikoehler wants to merge 1 commit intoaxiak:masterfrom
ulikoehler:basestring

Conversation

@ulikoehler
Copy link
Copy Markdown

When installing pyre2 using pip3 and subsequently importing it, I get the following error message:

Traceback (most recent call last):
  File "./katc.py", line 3, in <module>
    from check import performRender
  File "/home/uli/dev/KATranslationCheck/check.py", line 28, in <module>
    from Rules import Severity, importRulesForLanguage
  File "/home/uli/dev/KATranslationCheck/Rules.py", line 4, in <module>
    import re2 as re
  File "re2.pyx", line 1, in init re2 (src/re2.cpp:13681)

This pull request fixes that by defining basestring globally in the pyx file if it is not defined (i.e. in python3)

@ulikoehler
Copy link
Copy Markdown
Author

Hm, I think #33 also fixes this, so I'll close my PR

@ulikoehler ulikoehler closed this Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant