Skip to content

Conversation

@ravisinha0506
Copy link

Issue #, if available:

Description of changes:
Most of the dev stages are configured as test stage. As per existing code, test stage utilizes prod configuration. Hence, applying dev stage configuration to test stage as well

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ravisinha0506 ravisinha0506 requested a review from a team as a code owner November 28, 2025 23:26
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more time I spend with zap, the more I want to just always use the production logger to standardize tools. It has a nice side effect of leading decs towards making logs that will be readable in production.

Thoughts?

@JamesGAWS
Copy link

My 2c is that there's a lot of value in being able to configure lower logging levels for troubleshooting application behavior. I think having the ability to explicitly set logging level (instead of using stage as a proxy) has the advantage of being able to activate debug logging in select production scenarios where there's a need to debug customer specific behavior.

@ellistarn
Copy link
Contributor

My 2c is that there's a lot of value in being able to configure lower logging levels for troubleshooting application behavior. I think having the ability to explicitly set logging level (instead of using stage as a proxy) has the advantage of being able to activate debug logging in select production scenarios where there's a need to debug customer specific behavior.

Completely agree. If we're just using development to control log level, we should revisit this assumption. The main difference that I am familiar with is stack traces, console vs json, and log level.

I like James' suggestion as it keeps us as "production-like" as possible in development, while giving us the control we need.

@ellistarn
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants