feat(temporal): Limited support for Temporal#1416
feat(temporal): Limited support for Temporal#1416richarddavison merged 5 commits intoawslabs:mainfrom
Conversation
b4c9989 to
000ee83
Compare
3ec136d to
6b6484e
Compare
|
@richarddavison Please take a look when you have time. :) |
|
The choice of jiff is interesting vs chrono or time (which we probably already have in the tree) |
I really like Here is some interesting documentation about
|
|
@Sytten It would be great to optimize further if RquickJS supported seamless BigInt<->i128 conversion. Is there a good way to go about this? |
|
Make sense! I will have to check it, it is still niche for now so limited support in other libs. Not a fan that it has not seen a release in 1y+ As for BigInt the C API is limited an f64 as far as O remember. You can try to add an API in rquickjs but it will likely need to be added on the C side (guys are pretty responsive though). |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
We've added a few more supportable properties to ZonedDateTime. And that's really it. |
richarddavison
left a comment
There was a problem hiding this comment.
Nice! Thanks for the PR, some minor comments and questions to address other wise looks good!
36790d7 to
8cb8055
Compare
|
@richarddavison I think I've fixed most of the issues, but I'd like some further feedback on some of them. :) |
8cb8055 to
d27a4bd
Compare
|
@richarddavison I've rebased it onto the latest main. Of the issues you pointed out in the review, I believe there's only one remaining issue that needs to be resolved. Please let me know if there is anything else I should do. :) |
|
I've incorporated the last fix. |
Issue # (if available)
n/a
Description of changes
jiff, andllrt_temporalis merely a very thin wrapper to conform to the Temporal specification.In the future, we may consider usingtemporal_rsto have calendar functionality. However, it would be even better if we could switch to it in the backend for use cases that don't require a calendar, but that's not the goal of this PR.icuandjiff-icu(but not in this PR). If we do, we may place them after the feature gate due to the increased footprint.https://github.com/BurntSushi/jiff/blob/master/COMPARE.md#icu-v150
Not included in this PR (postponed to next time)
Temporal.Instant.round()Temporal.Duration.round()Temporal.Duration.total()Temporal.ZoneDateTime.round()Intl.DateTimeFormat()Checklist
tests/unitand/or in Rust for my feature if neededmake fixto format JS and apply Clippy auto fixesmake checktypes/directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.