Skip to content

feat(console): Improve console namespace compatibility#1258

Open
nabetti1720 wants to merge 3 commits intoawslabs:mainfrom
nabetti1720:feat/improve-console
Open

feat(console): Improve console namespace compatibility#1258
nabetti1720 wants to merge 3 commits intoawslabs:mainfrom
nabetti1720:feat/improve-console

Conversation

@nabetti1720
Copy link
Copy Markdown
Contributor

Description of changes

The console implementation has been tweaked to be more web standards compliant.

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nabetti1720 nabetti1720 changed the title feat(console): Improve console interface compatibility feat(console): Improve console namespace compatibility Nov 30, 2025
@nabetti1720 nabetti1720 marked this pull request as draft November 30, 2025 12:00
@nabetti1720 nabetti1720 marked this pull request as ready for review November 30, 2025 12:05
Copy link
Copy Markdown
Collaborator

@richarddavison richarddavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change. Thanks for this once!

Comment thread llrt_core/src/modules/console.rs Outdated
Comment thread llrt_core/src/modules/console.rs Outdated
@richarddavison
Copy link
Copy Markdown
Collaborator

F.Y.I blocked by: DelSkayn/rquickjs#572

@richarddavison
Copy link
Copy Markdown
Collaborator

@nabetti1720 this is now supported thanks to DelSkayn/rquickjs#659 feel free to update :)

@nabetti1720
Copy link
Copy Markdown
Contributor Author

@nabetti1720 this is now supported thanks to DelSkayn/rquickjs#659 feel free to update :)

Thank you for reporting this. I will definitely address it.

However, before that, it seems that incorporating the latest rquickjs commit will cause inconsistencies in the import attribute options, so we first need to create a pull request to upgrade the rquickjs version.

@nabetti1720
Copy link
Copy Markdown
Contributor Author

@richarddavison I believe all necessary corrections have been made.

@nabetti1720 nabetti1720 force-pushed the feat/improve-console branch 2 times, most recently from 88488aa to 7498da1 Compare April 18, 2026 20:55
@nabetti1720 nabetti1720 force-pushed the feat/improve-console branch from 7498da1 to 0a37f22 Compare April 18, 2026 21:06
@nabetti1720
Copy link
Copy Markdown
Contributor Author

@richarddavison If there are no other issues, you can merge it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants