feat(console): Improve console namespace compatibility#1258
Open
nabetti1720 wants to merge 3 commits intoawslabs:mainfrom
Open
feat(console): Improve console namespace compatibility#1258nabetti1720 wants to merge 3 commits intoawslabs:mainfrom
nabetti1720 wants to merge 3 commits intoawslabs:mainfrom
Conversation
richarddavison
requested changes
Dec 1, 2025
Collaborator
richarddavison
left a comment
There was a problem hiding this comment.
Minor change. Thanks for this once!
richarddavison
requested changes
Dec 5, 2025
56830a3 to
cd2e7db
Compare
Collaborator
|
F.Y.I blocked by: DelSkayn/rquickjs#572 |
Collaborator
|
@nabetti1720 this is now supported thanks to DelSkayn/rquickjs#659 feel free to update :) |
Contributor
Author
Thank you for reporting this. I will definitely address it. However, before that, it seems that incorporating the latest rquickjs commit will cause inconsistencies in the import attribute options, so we first need to create a pull request to upgrade the rquickjs version. |
5 tasks
cd2e7db to
0a6983a
Compare
Contributor
Author
|
@richarddavison I believe all necessary corrections have been made. |
richarddavison
approved these changes
Apr 13, 2026
88488aa to
7498da1
Compare
7498da1 to
0a37f22
Compare
Contributor
Author
|
@richarddavison If there are no other issues, you can merge it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The console implementation has been tweaked to be more web standards compliant.
Checklist
tests/unitand/or in Rust for my feature if neededmake fixto format JS and apply Clippy auto fixesmake checktypes/directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.