Merged
Conversation
SamRemis
reviewed
Jan 8, 2026
Contributor
|
Looks good over all - added some suggestions from Zizmor, which we should add to this repo to run over all GH actions to run by default in the long run. |
Contributor
Author
|
Thanks @SamRemis! I just pushed a new commit with the fixes added from running I opened this test PR to make sure this still runs properly. Example: API model change with NO changelog entry:
Workflow: https://github.com/jonathan343/aws-sdk-python/actions/runs/20889335156/job/60017993475 Example: API model change with a changelog entry: Workflow: https://github.com/jonathan343/aws-sdk-python/actions/runs/20889424472/job/60018217980 |
SamRemis
approved these changes
Jan 13, 2026
Contributor
SamRemis
left a comment
There was a problem hiding this comment.
Looks good! Thanks, Jonathan :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Add a GitHub Actions workflow to ensure changelog entries are added when manually updating AWS models. When a PR modifies files in
codegen/aws-models/, this workflow verifies that a corresponding changelog entry exists inclients/aws-sdk-<service>/.changes/next-release/.Workflow Behavior
modifies codegen/aws-models/*.jsonskip-changeloglabel presentValidation Requirements
A valid changelog entry must:
"type": "api-change"and a"description"fieldTest plan
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.