Open
Conversation
hariohmprasath
requested review from
DmitryGulin and
hariohmprasath
and removed request for
hariohmprasath
DmitryGulin
requested changes
Dec 14, 2022
Contributor
DmitryGulin
left a comment
DmitryGulin
left a comment
There was a problem hiding this comment.
kindly ask you to make sure that there is no unused code introduced.
| cpu: number; | ||
| memory: number; | ||
| environment?: Record<string, string>; | ||
| autoDeploymentsEnabled: boolean |
Contributor
There was a problem hiding this comment.
what is the reason for having a copy of that configuration parameter at the root level, although the only one defined on ICodeConfiguration interface is being used by the rest of the code?
| memory, | ||
| sourceConfig: imageUri ? getImageConfig(imageUri) : getSourceCodeConfig(), | ||
| environment: getEnvironmentVariables(envVarNames), | ||
| autoDeploymentsEnabled |
Comment on lines
+123
to
+124
| // AutoDeploymentsEnabled - true | ||
| const autoDeploymentsEnabled = getInputBool('auto-deployments-enabled', true) |
|
Is it just a matter of removing those three lines that is blocking this? Being able to disable the auto deploy upon commit functionality here would be super useful. |
|
It's embarrassing to see that its taking 3+ years to deal with such a simple thing. I think AWS has forgotten about the customers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Support
AutoDeploymentsEnabledDescription of changes:
Support
AutoDeploymentsEnabledBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.