docs: Add spec.sourceNamespaces requirement for EKS ArgoCD capability#1191
Open
yuwesu wants to merge 2 commits intoawsdocs:mainlinefrom
Open
docs: Add spec.sourceNamespaces requirement for EKS ArgoCD capability#1191yuwesu wants to merge 2 commits intoawsdocs:mainlinefrom
yuwesu wants to merge 2 commits intoawsdocs:mainlinefrom
Conversation
With EKS Argo CD Capability, the sourceNamespace is required because Amazon EKS by default doesn't whitelist any namespace.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1190
Description of changes:
This PR adds documentation for the spec.sourceNamespaces field, which is a required field when using the EKS ArgoCD capability.
spec.sourceNamespacesis required for EKS capability (differs from OSS ArgoCD)argocdnamespace; users modify to add additional namespacesargocdnamespace and all other required namespacesMotivation
The spec.sourceNamespaces field is mandatory for EKS ArgoCD capability but was not previously documented, which could lead to configuration errors for users.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.