-
Notifications
You must be signed in to change notification settings - Fork 760
Fix Service description: NodePort -> ClusterIP #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sredituo
wants to merge
1,147
commits into
awsdocs:mainline
Choose a base branch
from
sredituo:patch-1
base: mainline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added consideration for pod subnets
* add docs for the new associatePublicIPAddress field * add change log --------- Co-authored-by: Geoffrey Cline <geoffreyc@outlook.com>
…s#1082) * fix: fixed incorrect command for "Step 6: Scale down CoreDNS" * fix: fixed spelling issue
The aws eks create-cluster command was incorrect. The value in --resources-vpc-config subnetIds= argument had incorrect double quotations.
* hybrid node doc remove redundant newline * hybrid node doc add missing space * hybrid node doc fix broken link
Update create-node-class.adoc
Update automode-learn-instances.adoc
fix typo in auto mode release notes
updated ssm endpoint requirement for private cluster for ssm:RegisterManagedInstance api event
Highlight the generated key for NodeDiagnostic should be ends with .tar.gz
…er-access-policy Add AmazonEKSSecretReaderPolicy reference documentation in EKS Access Policy Reference
…ture document the new helm EBS CSI feaure for disabling mutating permissions
Update Cilium v1.17.9 and v1.18.3 support for EKS Hybrid Nodes
[AL2 EOS Prep] Update worker.adoc: AL2023/Nodeadm updates
[AL2 EOS Prep] Update cni-custom-network-tutorial.adoc
[AL2 EOS Prep] Update launch-templates.adoc
[AL2 EOS Prep] Update private-clusters.adoc to be specific to AL2023
…les (awsdocs#1167) This script analyzes all .adoc files in latest/ug/ to find broken xrefs. It processes files in parallel and detects both xref: and <<>> syntax forms, as well as multiple section ID formats including [[id]], [#id], and auto-generated IDs from section headers. The script reports: - Broken cross-references with file paths and line numbers - Duplicate section IDs across files - Summary statistics Results: Analyzed 394 files, found 3,878 section IDs and 2,241 xrefs, with only 2 broken xrefs (both placeholder examples in contribution docs). Co-authored-by: Claude <noreply@anthropic.com>
…-capacity docs: add auto mode static capacity docs
Added command and rectified document
Quickstart guide LLM inference on EKS with vLLM
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation currently states "Create a NodePort service" (in the "Key components" section).
However, the provided YAML manifest does not specify
type: NodePort, so it defaults toClusterIP.I have updated the text to "ClusterIP service".