chore: Run only the changed submodule's tests for test-only PRs#5936
Merged
Conversation
Previously detect-changes treated any change under a submodule as a source change, recursively pulling in all dependent submodules. For PRs that only touch a submodule's tests/ directory this ran the full suite unnecessarily. Add is_source_changed() and split detection into two passes: source changes still propagate to dependents, while test-only changes add just the changed submodule without propagation.
rsareddy0329
approved these changes
Jun 9, 2026
aviruthen
approved these changes
Jun 10, 2026
guanweim
pushed a commit
to guanweim/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2026
…5936) Previously detect-changes treated any change under a submodule as a source change, recursively pulling in all dependent submodules. For PRs that only touch a submodule's tests/ directory this ran the full suite unnecessarily. Add is_source_changed() and split detection into two passes: source changes still propagate to dependents, while test-only changes add just the changed submodule without propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously detect-changes treated any change under a submodule as a source change, recursively pulling in all dependent submodules. For PRs that only touch a submodule's tests/ directory this ran the full suite unnecessarily.
Add is_source_changed() and split detection into two passes: source changes still propagate to dependents, while test-only changes add just the changed submodule without propagation.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.