Fix: secure tar extraction issue#5587
Merged
Merged
Conversation
mollyheamazon
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mollyheamazon
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zhaoqizqwang
approved these changes
Feb 27, 2026
Evan-W-ang
added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
* Fix: secure tar extraction issue * Update unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5560
Summary
Fixes three security flaws in _repack_model.py that prevented tar extraction safety checks from working, allowing potential path traversal attacks.
Changes
Fixed iterator bug: Changed _get_safe_members(tar) to _get_safe_members(tar.getmembers(), base) - iterating over TarFile doesn't yield TarInfo
objects, causing checks to fail
Fixed base directory: Pass actual extraction path instead of current working directory - checks were validating against wrong location
Fixed path validation: Use os.path.commonpath() instead of startswith() - prevents bypass via paths like /tmp/x2 escaping base /tmp/x
Impact
Without these fixes, malicious tar archives could write files outside the intended extraction directory (tar slip attack).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.