Add Isort Checks for CI#5219
Closed
ParagEkbote wants to merge 8 commits into
Closed
Conversation
Author
|
Could anyone please review this PR? cc: @mollyheamazon |
Author
|
Could you please review? cc: @sage-maker |
Contributor
|
Can you provide a justification for this change? |
Author
As described in this issue, I have add isort checks to tox.
Could you please review? cc: @sage-maker |
Contributor
|
Please fix |
Author
|
I have add the missing cc: @sage-maker |
Contributor
|
You will still fail the CodeQL checks, please fix thanks |
Author
|
Closing this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1984
Description of changes: Added Isort for CI.
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.