Skip to content

Fix import error in integ tests and update PR check#134

Merged
zhaoqizqwang merged 2 commits intoaws:mainfrom
zhaoqizqwang:main
Jul 17, 2025
Merged

Fix import error in integ tests and update PR check#134
zhaoqizqwang merged 2 commits intoaws:mainfrom
zhaoqizqwang:main

Conversation

@zhaoqizqwang
Copy link
Copy Markdown
Collaborator

@zhaoqizqwang zhaoqizqwang commented Jul 17, 2025

  1. Fixed typo to cause integ test import error
  2. Reduce PR check to run integ test on only PY 3.11. This is to reduce cpu/memory load. Each integ test is requesting significant amount of cpu/memory. We might have insufficient resource available if many PR checks are raised at the same time

PR Approval Steps

For Requester

  1. Description
    • Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
    • Ensure that the PR follows the contribution guidelines, if applicable.
  2. Security requirements
    • Ensure that a Pull Request (PR) does not expose passwords and other sensitive information by using git-secrets and upload relevant evidence: https://github.com/awslabs/git-secrets
    • Ensure commit has GitHub Commit Signature
  3. Manual review
    1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
      • Code Quality: Check for coding standards, naming conventions, and readability.
      • Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
      • Security: Check for any security issues or vulnerabilities.
      • Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
  4. Check for Merge Conflicts:
    • Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

  1. Go through For Requester section to double check each item.
  2. Request Changes or Approve the PR:
    1. If the PR is ready to be merged, click Review changes and select Approve.
    2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
  3. Merging the PR
    1. Check the Merge Method:
      1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
    2. Merge the PR:
      1. Click the Merge pull request button.
      2. Confirm the merge by clicking Confirm merge.

@zhaoqizqwang zhaoqizqwang requested a review from a team as a code owner July 17, 2025 00:23
@zhaoqizqwang zhaoqizqwang changed the title Fix import error in integ tests Fix import error in integ tests and update PR check Jul 17, 2025
@zhaoqizqwang zhaoqizqwang merged commit 6c5f1be into aws:main Jul 17, 2025
15 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants