Replace hardcoded ECR account ID with region-based mapping#1055
Merged
Replace hardcoded ECR account ID with region-based mapping#1055
Conversation
| "ap-southeast-7": "963912059534", | ||
| "eu-central-2": "736184861541" | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
do we want to rename the file to make it more clear it's for smus Workflows local runner images, maybe like: workflows-local-runner-image-ecr-accounts.json
Contributor
There was a problem hiding this comment.
also, will need SMD team's review on maintaining a hardcoded account list
gnasrash
force-pushed
the
fix/ecr-account-id-by-region
branch
from
64994f0 to
51083e9
Compare
TRNWWZ
previously approved these changes
Feb 6, 2026
- Add region-to-account mapping for ap-east-1, af-south-1, eu-south-2, ap-southeast-5, ap-southeast-7, eu-central-2 - Replace hardcoded 058264401727 with ECR_ACCOUNT_ID variable in docker-compose.yaml - Update start-workflows-container.sh to set ECR_ACCOUNT_ID based on AWS_REGION - Apply changes to v2, v3, and v4 templates
gnasrash
force-pushed
the
fix/ecr-account-id-by-region
branch
from
51083e9 to
0964ccc
Compare
TRNWWZ
approved these changes
Feb 7, 2026
ruijiang-rjian
approved these changes
Feb 7, 2026
TRNWWZ
approved these changes
Feb 9, 2026
TRNWWZ
pushed a commit
that referenced
this pull request
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes]
Type of Change
Release Information
Does this change need to be included in patch version releases? By default, any pull requests will only be added to the next SMD image minor version release once they are merged in template folder. Only critical bug fix or security update should be applied to new patch versions of existed image minor versions.
If yes, please explain why:
[Explain the criticality of this change and why it should be included in patch releases]
How Has This Been Tested?
[Describe the tests you ran]
Checklist:
Test Screenshots (if applicable):
I have tested the changes by building the CPU image and deploying on my clouddesktop and ensuring that environment variable is set correctly
Related Issues
[Link any related issues here]
Additional Notes
[Any additional information that might be helpful for reviewers]