Conversation
claytonparnell
approved these changes
Jan 27, 2026
| f.write(container_logs) | ||
| print(f"Write env.out file successfully for image {image.id}, image type: {image_type}") | ||
|
|
||
| generate_change_log(target_version, image_generator_config) |
Contributor
There was a problem hiding this comment.
can building images parallelly cause write to the same changelog file simultaneously.
Contributor
Author
There was a problem hiding this comment.
image_generator_config is from https://github.com/aws/sagemaker-distribution/pull/1037/changes#diff-2e5ad92c43aa96cc3a9cef6c6aec998b216f1379c43b1f651013d25e55989312R341, whose image_type is either cpu or gpu. So it should be fine as generate_change_log method is writing to one image type only, no matter it runs in parallel or alone, shouldn't impact the output.
bhavya2109sharma
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Build cpu and gpu images in parallel
Type of Change
Release Information
Does this change need to be included in patch version releases? By default, any pull requests will only be added to the next SMD image minor version release once they are merged in template folder. Only critical bug fix or security update should be applied to new patch versions of existed image minor versions.
If yes, please explain why:
[Explain the criticality of this change and why it should be included in patch releases]
How Has This Been Tested?
Build images at local env
Checklist:
Test Screenshots (if applicable):
Related Issues
[Link any related issues here]
Additional Notes
[Any additional information that might be helpful for reviewers]