Add jupyter_server_documents to fix window OS file corruption due to CRLF#1030
Open
Add jupyter_server_documents to fix window OS file corruption due to CRLF#1030
Conversation
…; Disable manual enabling docprovider-extension because it will break JSD behavior
omursalo
approved these changes
Jan 21, 2026
omursalo
reviewed
Jan 21, 2026
| # Start Jupyter server in rtc mode for shared spaces | ||
| if [ -n "$SAGEMAKER_APP_TYPE_LOWERCASE" ] && [ "$SAGEMAKER_SPACE_TYPE_LOWERCASE" == "shared" ]; then | ||
| jupyter labextension enable @jupyter/collaboration-extension | ||
| jupyter labextension enable @jupyter/docprovider-extension |
Contributor
There was a problem hiding this comment.
Can you also test in SageMaker AI Studio since these changes would impact that environment too?
There was a problem hiding this comment.
Hey @rliuamzn , I was looking into integrating JSD on SMAI side. I am happy to assist you with any testing needed. Can we sync on this?
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug being fixed: Updates are broken on files using CRLF line terminators
Add jupyter_server_documents (JSD) and upgrade jupyter-collaboration to fix above bug in collaboration experience where files generated on windows OS will be broken upon edit inside JupyterLab. This issue has been currently fixed in JSD, PR177, but to incorporate that fix in SMD, we need to incorporate JSD into SMD.
JSD is the long-term collaboration library, which is based on juptyer-collaboration and disables a few conflicting extensions, such as jupyter-docprovider.
Package updates
Additional change:
In SMD 3 template, we need to remove all code that enables/disables jupyter-docprovider, which will break JSD functionality.
We don't need to do this in SMD2 template as there's no mentioning of jupyter-docprovider.
Type of Change
Release Information
Does this change need to be included in patch version releases? By default, any pull requests will only be added to the next SMD image minor version release once they are merged in template folder. Only critical bug fix or security update should be applied to new patch versions of existed image minor versions.
If yes, please explain why:
[Explain the criticality of this change and why it should be included in patch releases]
SMD customers that use windows OS to import files will experience broken experience.
How Has This Been Tested?
I have built 2 test images (SMD2 and SMD3) with the change and used these images in SM Space in my SMUS project. I uploaded test_num.py, a python file from window OS, and verified it will not be corrupted after edit.
SMD2 test recording:
smd_2_jsd.mov
SMD3 test recording:
smd_3_jsd.mov
Checklist:
Test Screenshots (if applicable):
Custom built images for SMD2 and 3 has been tested with JSD-0.1.0a9 previously.
Related Issues
[Link any related issues here]
jupyter-ai-contrib/jupyter-server-documents#176
Additional Notes
[Any additional information that might be helpful for reviewers]