Skip to content

Middleware test fix #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zhaozuy wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Middleware test fix #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac64968
fix(tests/middleware): add teardown method to clean up middleware eve…
zhaozuy Dec 5, 2025
50254bf
linting.
zhaozuy Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions python/tests/common/fastapi/middleware/test_middleware_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,31 @@ class TestMiddlewareExceptions:

def setup_method(self):
"""Clear global state before each test."""
from model_hosting_container_standards.common.fastapi.middleware.registry import (
middleware_registry,
)
from model_hosting_container_standards.common.fastapi.middleware.source.decorator_loader import (
decorator_loader,
)

# Clear decorator loader state
decorator_loader.clear()
# Clear middleware registry state
middleware_registry.clear_middlewares()

def teardown_method(self):
"""Clear global state after each test."""
from model_hosting_container_standards.common.fastapi.middleware.registry import (
middleware_registry,
)
from model_hosting_container_standards.common.fastapi.middleware.source.decorator_loader import (
decorator_loader,
)

# Clear decorator loader state
decorator_loader.clear()
# Clear middleware registry state
middleware_registry.clear_middlewares()

def test_middleware_registration_error_invalid_name(self):
"""Test MiddlewareRegistrationError for invalid middleware name."""
Expand Down Expand Up @@ -121,12 +140,6 @@ def second_input_formatter():

def test_exception_chaining(self):
"""Test that exceptions are properly chained with 'from' clause."""
from model_hosting_container_standards.common.fastapi.middleware.registry import (
middleware_registry,
)

# Clear the global registry first
middleware_registry.clear_middlewares()

# First register a middleware using decorator
@custom_middleware("pre_post_process")
Expand All @@ -143,6 +156,3 @@ def duplicate_middleware():
# Check that the original ValueError is chained
assert exc_info.value.__cause__ is not None
assert isinstance(exc_info.value.__cause__, ValueError)

# Clean up
middleware_registry.clear_middlewares()