Skip to content

Comments

revert: rename retrieved_memory tag back to user_context#278

Closed
notgitika wants to merge 1 commit intomainfrom
revert/retrieved-memory-tag-rename
Closed

revert: rename retrieved_memory tag back to user_context#278
notgitika wants to merge 1 commit intomainfrom
revert/retrieved-memory-tag-rename

Conversation

@notgitika
Copy link
Contributor

@notgitika notgitika commented Feb 23, 2026

Summary

Reverts the <user_context><retrieved_memory> tag rename introduced in #271. This tag rename is a breaking change for users who reference <user_context> in system prompts or parsing logic.

The core prefill fix from #271 (inserting memory before the last user message) is not affected — only the tag name is reverted.

A configurable context_tag parameter is proposed in #277 so users can opt in to a custom tag name without breaking existing setups.

Test plan

  • All <retrieved_memory> references replaced with <user_context> in source + tests
  • Unit tests pass
  • Integration tests pass

@notgitika notgitika requested a review from a team February 23, 2026 17:09
@notgitika notgitika force-pushed the revert/retrieved-memory-tag-rename branch from d23dfdd to 7df8315 Compare February 23, 2026 17:13
Copy link
Contributor

@jariy17 jariy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just check what failed the workflow linter.

@notgitika notgitika closed this Feb 23, 2026
@notgitika
Copy link
Contributor Author

notgitika commented Feb 23, 2026

raised another PR makign it configurable: #279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants