Skip to content

Fix upload directory progress inconsistency #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philasmar wants to merge 6 commits into from
Closed

Fix upload directory progress inconsistency #4258

philasmar wants to merge 6 commits into from

Conversation

@philasmar
Copy link
Contributor

@philasmar philasmar commented Dec 23, 2025 •
edited
Loading

Description

Fix upload directory progress inconsistency

Motivation and Context

Fix upload directory progress inconsistency

Testing

Ran dry run 45fc93e2-e81b-4094-b712-0cb1b8ab761e

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

GarrettBeatty
GarrettBeatty approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@GarrettBeatty GarrettBeatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved assuming you add dev config

@philasmar
Copy link
Contributor Author

philasmar commented Jan 5, 2026

Will not merge due to the impact of change and failed tests

@philasmar philasmar closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GarrettBeatty GarrettBeatty GarrettBeatty approved these changes

@afroz429 afroz429 afroz429 approved these changes

@AlexDaines AlexDaines AlexDaines approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@philasmar @GarrettBeatty @afroz429 @AlexDaines