Generate GetBucketLogging

[peterrsongg]

Stacked PRs:

• Generate PutBucketLogging #4250
• ->Generate GetBucketLogging #4249

---

Description

Generate GetBucketLogging

Motivation and Context

Testing

Assembly Comparison output empty (no backwards incompatible changes)
Fuzz Testing run: No backwards incompatibilities
DRY_RUN passed 7b1db732-7d93-4e80-ba86-5301f393e2ae

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license

[peterrsongg]

READ THIS

S3BucketLoggingConfig does contain those three public methods. It has been preserved.

Breaking Changes Analysis for GetBucketLogging Migration

Files Analyzed: 19 of 19

BREAKING CHANGE FOUND:

---

File: S3BucketLoggingConfig.cs

Issue Type: Public API Methods Removed

Details:

The custom S3BucketLoggingConfig.cs file previously contained three public methods that have been completely removed in the migration to generated code:

1. public void AddGrant(S3Grantee grantee, S3Permission permission)

   • Allowed users to programmatically add grants to the Grants collection
   • Created a new S3Grant object and added it to the Grants list

2. public void RemoveGrant(S3Grantee grantee, S3Permission permission)

   • Allowed users to remove a specific grant with a specific permission
   • Searched the Grants collection for matching grantee and permission

3. public void RemoveGrant(S3Grantee grantee)

   • Allowed users to remove all grants for a given grantee
   • Removed all S3Grant objects from the Grants collection that matched the grantee

Impact:

Any customer code that calls these methods will break at compile time. These were convenience methods for managing the Grants collection.

Previous Code (Custom):

public partial class S3BucketLoggingConfig
{
    public void AddGrant(S3Grantee grantee, S3Permission permission)
    {
        if (Grants == null)
        {
            Grants = new List<S3Grant>();
        }
        S3Grant grant = new S3Grant{ Grantee = grantee, Permission = permission };
        Grants.Add(grant);
    }

    public void RemoveGrant(S3Grantee grantee, S3Permission permission) { ... }
    public void RemoveGrant(S3Grantee grantee) { ... }
}

Current Code (Generated):

public partial class S3BucketLoggingConfig
{
    // Methods completely removed
    // Only properties remain: Grants, TargetBucketName, TargetObjectKeyFormat, TargetPrefix
}

---

Non-Breaking Changes Successfully Preserved:

1. ✅ GetBucketLoggingResponse.BucketLoggingConfigCustomGetter() - Custom getter preserved via injectXmlPropertyGetter customization
2. ✅ GetBucketLoggingRequestMarshaller.PreMarshallCustomization() - Suppress404Exceptions logic preserved in custom partial
3. ✅ GetBucketLoggingRequest.IsSetExpectedBucketOwner() - Uses !String.IsNullOrEmpty() as specified in customizations
4. ✅ Property name mappings - TargetBucket→TargetBucketName and TargetGrants→Grants correctly applied
5. ✅ Unmarshaller logic - GetBucketLoggingResponseUnmarshaller properly unmarshalls to S3BucketLoggingConfig using S3BucketLoggingConfigUnmarshaller
6. ✅ XML parsing paths - TargetGrants/Grant path correctly specified in generated unmarshaller
7. ✅ IsSet methods - All generated IsSet methods use appropriate null checks
8. ✅ PutBucketLoggingRequestMarshaller - Remains unchanged and compatible with generated model

---

Summary:

Total Files Changed: 19
Files Analyzed: 19 of 19
Breaking Changes: 1
Files with Issues: 1

The migration successfully preserved most of the custom behavior through the partial class pattern and customizations. However, the removal of the three public helper methods from S3BucketLoggingConfig represents a breaking API change that will affect any customers currently using these methods to manage bucket logging grants.

[dscpinheiro]

This file is replacing https://github.com/aws/aws-sdk-net/blob/main/sdk/src/Services/S3/Custom/Model/Internal/MarshallTransformations/LoggingEnabledUnmarshaller.cs, right?

If yes, should (could?) that file be deleted in the PR too? And the old unmarshaller uses context.TestExpression("Grant", targetDepth + 1) instead, I assume that's because it was hand-written?

[peterrsongg]

yeah it should be removed, it isn't gonna be used anymore. However, I'm running into some annoying merge conflict / build issues with all the code under review rn and the stuff muhammad released. I'll wait to update this, until the 5 other open PRs are merged so that I can just rebase on development

[peterrsongg]

lots of newly generated s3 operations are making the diff hard to review. closing and will re-open a PR that is easier to review.