Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/issue-regression-labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,16 @@ jobs:
else
gh issue edit ${{ github.event.issue.number }} --remove-label "potential-regression" -R ${{ github.repository }}
fi
- name: Notify Slack
if: steps.check_regression.outputs.is_regression == 'true' && github.event.action == 'opened'
run: |
curl -sfS -X POST "$SLACK_WEBHOOK_URL" \
-H 'Content-type: application/json' \
--data "$(jq -n \
--arg text "🚨 Potential regression reported: <$ISSUE_URL|#$ISSUE_NUM: $ISSUE_TITLE>" \
'{text: $text}')"
env:
SLACK_WEBHOOK_URL: ${{ secrets.CI_SLACK_WEBHOOK_URL }}
ISSUE_URL: ${{ github.event.issue.html_url }}
ISSUE_NUM: ${{ github.event.issue.number }}
ISSUE_TITLE: ${{ github.event.issue.title }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a part of the body of the Github issue as well?
Maybe only the first 100 words or something so we can assess the issue without clicking through to Github.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea - I considered it too. My primary intention of this notification is to prompt us to triage the issue as soon as possible, so clicking through to the issue is the intended action. Then looking at past regression issues, the titles were quite descriptive, so I felt adding body content could make the channel messy. Additonally, it also may contain markdown, code blocks, stack traces that may not render cleanly in Slack. Happy to revisit if we find the title alone isn't enough, WDYT?

Loading